Chore: Remove controllers specs and gem (TheOdinProject#3008)

Because: * Controller tests are deprecated This commit: * Remove rails-controller-testing gem * Remove spec/controllers * Fix broken request specs by removing render_template calls
rebsrebs · Jun 26, 2022 · d7a1af8 · d7a1af8
1 parent 1d8797e
commit d7a1af8
Show file tree

Hide file tree

Showing 10 changed files with 1 addition and 161 deletions.
diff --git a/Gemfile b/Gemfile
@@ -64,7 +64,6 @@ group :test do
   gem 'cuprite', '~> 0.13'
   gem 'erb_lint', '~> 0.1', require: false
   gem 'factory_bot_rails', '~> 6.2'
-  gem 'rails-controller-testing', '~> 1.0'
   gem 'rspec-retry', '~> 0.6'
   gem 'shoulda-matchers', '~> 5.1'
   gem 'simplecov', '~> 0.21', require: false

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -371,10 +371,6 @@ GEM
       bundler (>= 1.15.0)
       railties (= 6.1.4.6)
       sprockets-rails (>= 2.0.0)
-    rails-controller-testing (1.0.5)
-      actionpack (>= 5.0.1.rc1)
-      actionview (>= 5.0.1.rc1)
-      activesupport (>= 5.0.1.rc1)
     rails-dom-testing (2.0.3)
       activesupport (>= 4.2.0)
       nokogiri (>= 1.6)
@@ -587,7 +583,6 @@ DEPENDENCIES
   rack-attack (~> 6.6)
   rack-mini-profiler
   rails (= 6.1.4.6)
-  rails-controller-testing (~> 1.0)
   react-rails (~> 2.6)
   rspec-rails (~> 5.1)
   rspec-retry (~> 0.6)

diff --git a/spec/controllers/errors_controller_spec.rb b/spec/controllers/errors_controller_spec.rb
diff --git a/spec/controllers/paths_controller_spec.rb b/spec/controllers/paths_controller_spec.rb
diff --git a/spec/controllers/registrations_controller_spec.rb b/spec/controllers/registrations_controller_spec.rb
diff --git a/spec/controllers/sitemap_controller_spec.rb b/spec/controllers/sitemap_controller_spec.rb
diff --git a/spec/controllers/users_controller_spec.rb b/spec/controllers/users_controller_spec.rb
diff --git a/spec/requests/paths_spec.rb b/spec/requests/paths_spec.rb
@@ -10,7 +10,7 @@
 
         get path_url(path)
 
-        expect(response).to render_template(:show)
+        expect(response).to have_http_status(:ok)
       end
     end
 

diff --git a/spec/requests/redirects_spec.rb b/spec/requests/redirects_spec.rb
@@ -22,9 +22,6 @@
 
       expect(response).to redirect_to('/lessons/test-course-test-lesson')
       expect(response).to have_http_status(:moved_permanently)
-      follow_redirect!
-
-      expect(response).to render_template(:show)
     end
 
     context "when the course doesn't exist" do
@@ -33,9 +30,6 @@
 
         expect(response).to redirect_to('/paths')
         expect(response).to have_http_status(:moved_permanently)
-        follow_redirect!
-
-        expect(response).to render_template(:index)
       end
     end
 
@@ -47,9 +41,6 @@
 
         expect(response).to redirect_to('/paths')
         expect(response).to have_http_status(:moved_permanently)
-        follow_redirect!
-
-        expect(response).to render_template(:index)
       end
     end
   end

diff --git a/spec/requests/static_pages_spec.rb b/spec/requests/static_pages_spec.rb
@@ -6,7 +6,6 @@
       get home_path
 
       expect(response).to have_http_status(:ok)
-      expect(response).to render_template(:home)
     end
   end
 
@@ -15,7 +14,6 @@
       get about_path
 
       expect(response).to have_http_status(:ok)
-      expect(response).to render_template(:about)
     end
   end
 
@@ -24,7 +22,6 @@
       get terms_of_use_path
 
       expect(response).to have_http_status(:ok)
-      expect(response).to render_template(:terms_of_use)
     end
   end
 
@@ -33,7 +30,6 @@
       get success_stories_path
 
       expect(response).to have_http_status(:ok)
-      expect(response).to render_template(:success_stories)
     end
   end
 end
-Original file line number
+Diff line change
@@ Expand Up / @@ -10,7 +10,7 @@ @@
             get path_url(path)
-            expect(response).to render_template(:show)
+            expect(response).to have_http_status(:ok)
           end
         end
@@ Expand Down @@