Improved error handling when starting webdriver fails

recmh · Dec 1, 2018 · c3dfb16 · c3dfb16
1 parent efc5630
commit c3dfb16
Show file tree

Hide file tree

Showing 6 changed files with 14 additions and 5 deletions.
diff --git a/bin/runner.js b/bin/runner.js
@@ -28,6 +28,7 @@ try {
       });
   });
 } catch (err) {
+  err.message = 'An error occurred while trying to start the Nightwatch Runner: ' + err.message;
   Logger.error(err);
   process.exit(2);
 }
diff --git a/lib/runner/cli/cli.js b/lib/runner/cli/cli.js
@@ -207,7 +207,7 @@ class CliRunner {
     }
 
     return WebDriver.startInstances().catch(err => {
-      Logger.error(err.toString() + '\n');
+      Logger.error(err);
 
       if (err.errorOut) {
         Logger.error(err.errorOut);

diff --git a/lib/runner/wd-instances/base-wd-server.js b/lib/runner/wd-instances/base-wd-server.js
@@ -330,7 +330,15 @@ class BaseWDServer {
     this.startTime = new Date();
 
     this.setCliArgs();
-    this.createProcess();
+    try {
+      this.createProcess();
+    } catch (err) {
+      err.message = `Error while trying to create ${this.serviceName} process: ${err.message}.`;
+      err.detailedErr = 'For more info about Node.js errors see https://nodejs.org/api/errors.html';
+
+      return Promise.reject(err);
+    }
+
 
     this.process.stdout.on('data', this.onStdout.bind(this));
     this.process.stderr.on('data', this.onStderr.bind(this));

diff --git a/lib/runner/wd-instances/chromedriver.js b/lib/runner/wd-instances/chromedriver.js
@@ -22,7 +22,7 @@ class ChromeDriver extends BaseWDServer {
   }
 
   get serviceName() {
-    return 'ChromeDriver';
+    return ChromeDriver.serviceName;
   }
 }
 

diff --git a/lib/runner/wd-instances/geckodriver.js b/lib/runner/wd-instances/geckodriver.js
@@ -14,7 +14,7 @@ class GeckoDriver extends BaseWDServer {
   }
 
   get serviceName() {
-    return 'GeckoDriver';
+    return GeckoDriver.serviceName;
   }
 
   get serviceDownloadUrl() {

diff --git a/lib/runner/wd-instances/safaridriver.js b/lib/runner/wd-instances/safaridriver.js
@@ -33,7 +33,7 @@ class SafariDriver extends BaseWDServer {
   }
 
   get serviceName() {
-    return 'SafariDriver';
+    return SafariDriver.serviceName;
   }
 
   constructor(settings) {
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,7 +22,7 @@ class ChromeDriver extends BaseWDServer { @@
       }
       get serviceName() {
-        return 'ChromeDriver';
+        return ChromeDriver.serviceName;
       }
     }
@@ Expand Down @@