Skip to content

ioredis migration docs suggestions #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PavelPashov
Copy link
Contributor

@PavelPashov PavelPashov commented Jun 5, 2025

Below are some findings and suggestions for improving the ioredis migration docs

ioredis migration suggestions

Initial Connection

The below await in the node-redis section is redundant

const client = await createClient();

Asynchronous command result handling

node-redis supports callbacks via Legacy Mode

SETNX command

node-redis has a SETNX command

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Pavel Pashov seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PavelPashov PavelPashov marked this pull request as ready for review June 5, 2025 07:59
Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small suggestions, but basically LGTM.

Co-authored-by: andy-stark-redis <[email protected]>
@andy-stark-redis andy-stark-redis merged commit 82ba699 into redis:main Jun 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants