DOC-5503 enable TCE overrides #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwdougherty
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
@andy-stark-redis: this looks great! I do have a couple of suggestions:
- Maybe create per-language buckets under local_examples? Otherwise, it could get ugly very quickly.
- Augie created the runnable local_examples.py file, but maybe that won't be needed? If not, I'd suggest integrating the local examples processing into the existing build/components and/or build/examples structure.
No hurry on either of these; both can wait until another time. Also, I have no quarrel if you decide you'd rather not do either.
I like the idea of named parameters. Augie could probably make fast work of it.
|
Thanks @dwdougherty ! I'll merge this in its current state and fix the time series examples, etc, then I'll get on with implementing your suggestions. |
cmilesb
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
Agree with @dwdougherty's suggestions and also agree with adding named parameters for all of this, but it otherwise looks great! Thank you for taking a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOC-5503
This builds on David's great start, modifying the build to allow local TCE example files. The further changes are:
clients-exampleshortcode).I've left the
/develop/clients/test-local-examplestest file in place and also the example local source files in thelocal_examplesfolder. These files demonstrate the changes but of course, I'll delete them before merging :-)Also, with all these parameters to this shortcode now, maybe we should consider switching to named parameters? This would be a separate PR, as it would involve changing all the existing TCEs, but it might be neater and more convenient to use.