feat: recover addIdleConn may occur panic #2445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: monkey92t <[email protected]>
Signed-off-by: monkey92t <[email protected]>
ndyakov
approved these changes
Aug 5, 2025
There was a problem hiding this comment.
@monkey92t this is a great idea, will include this once the build is green.
ofekshenawa
pushed a commit
that referenced
this pull request
Aug 10, 2025
* feat: recover addIdleConn may occur panic Signed-off-by: monkey92t <[email protected]> * fix test race Signed-off-by: monkey92t <[email protected]> --------- Signed-off-by: monkey92t <[email protected]> Co-authored-by: Nedyalko Dyakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user defines the
Dialerfunction, we should userecoverto capture the panic thataddIdleConnmay generate.