ReadFromAny (master+replica) without cluster mode (Master-Replica setup) #2995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@singh-bhawani thank you for the contribution! Would you please add tests to cover the code you are introducing? |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for read-only commands to be routed to both master and replica nodes in a master-replica setup.
- Introduces a new boolean flag "ReadFromAny" to the FailoverOptions struct.
- Updates the masterReplicaDialer to select a random address when reading from any node.
- Implements a new method RandomAddr that aggregates replica addresses and the master address.
| } | ||
| } | ||
|
|
||
| masterAdd, _ := c.MasterAddr(ctx) |
There was a problem hiding this comment.
Consider handling the error returned by c.MasterAddr(ctx) to ensure that the master address is valid before appending it to the addresses pool.
Suggested change
| masterAdd, _ := c.MasterAddr(ctx) | |
| masterAdd, err := c.MasterAddr(ctx) | |
| if err != nil { | |
| return "", err | |
| } |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, with go-redis, we can't read from both the Master and its Replica without being in cluster mode. Also, when we use "ReplicaOnly", it randomly chooses Replica to read. This causes a problem because caching is mainly used for read heavy usecase, which means the Master only used for write throughput and it's resource are underutilized.
To solve this, I added "ReadFromAny" to "FailoverOptions". This means that read-only commands will come from both Replicas as well as Master. This way, we can make better use of the caching resource.