Skip to content

fix(options): Add buffer sizes to failover. Update README #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 11, 2025
Merged

fix(options): Add buffer sizes to failover. Update README #3468

merged 4 commits into from
Aug 11, 2025
+65 −23

Conversation

ndyakov
Copy link
Member

@ndyakov ndyakov commented Aug 11, 2025 •
edited
Loading

  • add missing buffer size to failover options
  • half the default buffer size
  • add section in readme related to buffer sizes

Fixes #3465

@ndyakov ndyakov requested a review from ofekshenawa August 11, 2025 09:56
@ndyakov ndyakov added the bug label Aug 11, 2025
@htemelski-redis htemelski-redis self-requested a review August 11, 2025 10:23
ndyakov
ndyakov commented Aug 11, 2025
View reviewed changes
ndyakov
ndyakov commented Aug 11, 2025
View reviewed changes
htemelski-redis
htemelski-redis reviewed Aug 11, 2025
View reviewed changes
htemelski-redis
htemelski-redis previously approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@htemelski-redis htemelski-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good there are two minor things to change but they are already noted

ofekshenawa
ofekshenawa approved these changes Aug 11, 2025
View reviewed changes
Copy link
Collaborator

@ofekshenawa ofekshenawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndyakov ndyakov merged commit 94cfffa into master Aug 11, 2025
47 of 48 checks passed
@htemelski-redis htemelski-redis deleted the ndyakov/buffer-size-failover branch August 11, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofekshenawa ofekshenawa ofekshenawa approved these changes

@htemelski-redis htemelski-redis htemelski-redis left review comments

Assignees
No one assigned
Labels
bug maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Potential memory leaks on 9.12.0
3 participants
@ndyakov @ofekshenawa @htemelski-redis