Skip to content

Conversation

tishun
Copy link
Collaborator

@tishun tishun commented Aug 19, 2025

Closes #3294

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@tishun tishun force-pushed the topic/tishu/issue-3294 branch from 97215ef to b21da6d Compare August 20, 2025 09:39
@tishun tishun requested review from ggivo, a-TODO-rov and uglide August 20, 2025 09:49
@tishun
Copy link
Collaborator Author

tishun commented Aug 20, 2025

@a-TODO-rov , @ggivo before merging we need to test carefully the native transports integration

@tishun
Copy link
Collaborator Author

tishun commented Aug 25, 2025

Good to also check the following, according to the migration guide::

  • Ensure endpoint validation is explicitly configured for client TLS connections.
  • Explicitly configure your system to use the pooled allocator.

@rhanton
Copy link

rhanton commented Sep 11, 2025

Upvoting this issue 👍 . This is transitively causing me grief over CVE-2025-58057 in netty < 4.1.125 via lettuce via spring-data-redis. Thanks for the work @tishun !

@ggivo
Copy link
Contributor

ggivo commented Sep 16, 2025

@a-TODO-rov , @ggivo before merging we need to test carefully the native transports integration

@tishun
By testing, do you have something specific in mind?
What comes to my mind is to run existing integration test using lettuce configured with (netty-transport-classes-epoll & netty-transport-classes-io_uring ) on Linux & netty-transport-classes-kqueue on ОСѝ?

@tishun
Copy link
Collaborator Author

tishun commented Sep 16, 2025

By testing I meant that for all three native transports - io_uring, kqueue and epoll - we need to start some test load and verify the driver loads and works as expected. No need to run the entire suite of E2E tests, but if it is easy we can also do that.

@tishun
Copy link
Collaborator Author

tishun commented Sep 16, 2025

Good to also check the following, according to the migration guide::

  • Ensure endpoint validation is explicitly configured for client TLS connections.
  • Explicitly configure your system to use the pooled allocator.

I think we are good on the sslContextBuilder.endpointIdentificationAlgorithm(String) part too.

@tishun
Copy link
Collaborator Author

tishun commented Sep 16, 2025

Good to also check the following, according to the migration guide::

  • Ensure endpoint validation is explicitly configured for client TLS connections.
  • Explicitly configure your system to use the pooled allocator.

For the pooled allocator I think we can go ahead and use the adaptive one. This is a breaking change, but we are making a major release, so we should be fine. Users can easily override that if they want to use the pooled allocator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider upgrading to Netty 4.2
3 participants