Test against unstable hiredis-py #3617
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The guard was required to prevent cluster tests on RESP3 with hiredis-py before 3.1.0
There was a problem hiding this comment.
Pull Request Overview
This PR introduces integration tests to verify functionality against the unstable version of hiredis-py.
- Adds a new GitHub Actions workflow (.github/workflows/hiredis-py-integration.yaml) to run integration tests with different Python and Redis versions.
- Enhances the run-tests action (.github/actions/run-tests/action.yml) by including a new input for the hiredis branch and adding steps to checkout and install the unstable version of hiredis-py.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/hiredis-py-integration.yaml | New workflow to run hiredis-py integration tests. |
| .github/actions/run-tests/action.yml | Updated action inputs and installation steps for unstable hiredis-py. |
|
@uglide how will the new workflow be triggered? Currently, I don't see it in the pipelines executed for the branch. Can you please provide some reference to another repo where similar workflow is used? |
|
@petyaslavova the idea is to be able to trigger it manually to cross-check changes in hiredis-py against redis-py tests. |
petyaslavova
added a commit
to Kakadus/redis-py
that referenced
this pull request
May 13, 2025
* Test against unstable hiredis-py * Create a separate workflow instead * Remove outdated guard for hiredis-py The guard was required to prevent cluster tests on RESP3 with hiredis-py before 3.1.0 --------- Co-authored-by: petyaslavova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.