Added MultiDbClient support with OSS Cluster API #3734
+488
−168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…v-multi-db-client
…v-active-active-pipeline
…ement, fixed data structure
…v-active-active-pipeline
… into vv-pubsub-support
…v-active-active-pipeline
… into vv-pubsub-support
… into vv-pubsub-support
|
It seems that the pubsub changes for the standalone are part of this change together with the newly added sharded_pubsub changes and are causing conflicts. Other than that, the changes are looking good. |
| sleep(0.1) |
There was a problem hiding this comment.
0.1 might be too spamy on the logs, I usually do 0.5 or 1-3 seconds, but Idk if in your usecase its not 100% needed to be 0.1
| ) | ||
| @pytest.mark.timeout(50) | ||
| def test_pubsub_failover_to_another_db(self, r_multi_db, fault_injector_client): |
There was a problem hiding this comment.
Do you plan on doing multi? Idk if it's needed for the AA, but it might be helpful to discover issues? Maybe some blocking command. (I've not the same AA context as you, so feel free to ignore this comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.