Skip to content

Commit

Permalink
build: upgrade Rust to 1.50.0 (denoland#645)
Browse files Browse the repository at this point in the history
  • Loading branch information
bnoordhuis authored Mar 16, 2021
1 parent a71575a commit 25608cc
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
uses: hecrj/setup-rust-action@v1
with:
components: clippy, rustfmt
rust-version: 1.49.0
rust-version: 1.50.0

- name: Install python
uses: actions/setup-python@v1
Expand Down
11 changes: 10 additions & 1 deletion tests/test_api.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2007,6 +2007,9 @@ fn module_instantiation_failures1() {
}
}

// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn compile_specifier_as_module_resolve_callback<'a>(
context: v8::Local<'a, v8::Context>,
specifier: v8::Local<'a, v8::String>,
Expand Down Expand Up @@ -2066,6 +2069,9 @@ fn import_assertions() {
let _setup_guard = setup();
let isolate = &mut v8::Isolate::new(Default::default());

// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn module_resolve_callback<'a>(
context: v8::Local<'a, v8::Context>,
_specifier: v8::Local<'a, v8::String>,
Expand Down Expand Up @@ -3556,7 +3562,7 @@ fn take_heap_snapshot() {
true
});
let s = std::str::from_utf8(&vec).unwrap();
assert!(s.find(r#""Eyecatcher""#).is_some());
assert!(s.contains("Eyecatcher"));
}
}

Expand Down Expand Up @@ -3875,6 +3881,9 @@ fn low_memory_notification() {
isolate.low_memory_notification();
}

// Clippy thinks the return value doesn't need to be an Option, it's unaware
// of the mapping that MapFnFrom<F> does for ResolveModuleCallback.
#[allow(clippy::unnecessary_wraps)]
fn synthetic_evaluation_steps<'a>(
context: v8::Local<'a, v8::Context>,
module: v8::Local<v8::Module>,
Expand Down

0 comments on commit 25608cc

Please sign in to comment.