Allow ref for insertBefore to be null

CHANGELOG.md

@@ -4,6 +4,7 @@
 - Fix overload declarations for `quill.formatText()` and other methods
 - Expose Bounds type for getBounds()
 - Expose Range type
+- Allow ref for insertBefore to be null
 
 # 2.0.0-rc.4
 

packages/quill/package.json

@@ -9,7 +9,7 @@
  "dependencies": {
  "eventemitter3": "^5.0.1",
  "lodash-es": "^4.17.21",
- "parchment": "3.0.0-rc.0",
+ "parchment": "3.0.0-rc.1",
  "quill-delta": "^5.1.0"
  },
  "devDependencies": {

packages/quill/src/blots/block.ts

@@ -90,7 +90,6 @@ class Block extends BlockBlot {
  }
 
  moveChildren(target: Parent, ref?: Blot | null) {
- // @ts-expect-error Parchment types are wrong
  super.moveChildren(target, ref);
  this.cache = {};
  }
@@ -116,7 +115,6 @@ class Block extends BlockBlot {
  this.parent.insertBefore(clone, this);
  return this;
  }
- // @ts-expect-error Fix me later
  this.parent.insertBefore(clone, this.next);
  return clone;
  }
@@ -172,11 +170,9 @@ class BlockEmbed extends EmbedBlot {
  });
  const ref = this.split(index);
  blocks.forEach((block) => {
- // @ts-expect-error Fix me later
  this.parent.insertBefore(block, ref);
  });
  if (text) {
- // @ts-expect-error Fix me later
  this.parent.insertBefore(this.scroll.create('text', text), ref);
  }
  }

packages/quill/src/blots/embed.ts

@@ -65,7 +65,6 @@ class Embed extends EmbedBlot {
  };
  } else {
  textNode = document.createTextNode(text);
- // @ts-expect-error Fix me later
  this.parent.insertBefore(this.scroll.create(textNode), this.next);
  range = {
  startNode: textNode,

packages/quill/src/blots/scroll.ts

@@ -124,7 +124,7 @@ class Scroll extends ScrollBlot {
  this.optimize();
  }
 
- insertBefore(blot: Blot, ref?: Blot) {
+ insertBefore(blot: Blot, ref?: Blot | null) {
  if (blot.statics.scope === Scope.INLINE_BLOT) {
  const wrapper = this.scroll.create(
  this.statics.defaultChild.blotName,

packages/quill/src/core/selection.ts

@@ -162,7 +162,6 @@ class Selection {
  // TODO Give blot ability to not split
  if (blot instanceof LeafBlot) {
  const after = blot.split(nativeRange.start.offset);
- // @ts-expect-error Fix me later
  blot.parent.insertBefore(this.cursor, after);
  } else {
  // @ts-expect-error TODO: nativeRange.start.node doesn't seem to match function signature