Skip to content

Commit

Permalink
fix(server): update asset with tagged people (immich-app#4000)
Browse files Browse the repository at this point in the history
  • Loading branch information
jrasm91 authored Sep 6, 2023
1 parent c1f4fe6 commit 15bfceb
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
4 changes: 3 additions & 1 deletion server/src/infra/repositories/asset.repository.ts
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ export class AssetRepository implements IAssetRepository {
owner: true,
smartInfo: true,
tags: true,
faces: true,
faces: {
person: true,
},
},
});
}
Expand Down
29 changes: 28 additions & 1 deletion server/test/e2e/asset.e2e-spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { IAssetRepository, LoginResponseDto } from '@app/domain';
import { IAssetRepository, IFaceRepository, IPersonRepository, LoginResponseDto } from '@app/domain';
import { AppModule, AssetController } from '@app/immich';
import { AssetEntity, AssetType } from '@app/infra/entities';
import { INestApplication } from '@nestjs/common';
Expand Down Expand Up @@ -132,5 +132,32 @@ describe(`${AssetController.name} (e2e)`, () => {
});
expect(status).toEqual(200);
});

it('should return tagged people', async () => {
const personRepository = app.get<IPersonRepository>(IPersonRepository);
const person = await personRepository.create({ ownerId: asset1.ownerId, name: 'Test Person' });

const faceRepository = app.get<IFaceRepository>(IFaceRepository);
await faceRepository.create({ assetId: asset1.id, personId: person.id });

const { status, body } = await request(server)
.put(`/asset/${asset1.id}`)
.set('Authorization', `Bearer ${user1.accessToken}`)
.send({ isFavorite: true });
expect(status).toEqual(200);
expect(body).toMatchObject({
id: asset1.id,
isFavorite: true,
people: [
{
birthDate: null,
id: expect.any(String),
isHidden: false,
name: 'Test Person',
thumbnailPath: '',
},
],
});
});
});
});

0 comments on commit 15bfceb

Please sign in to comment.