Performance improvement by limiting calls to localStorage.getItem().

remmeier · May 1, 2014 · 24a0798 · 24a0798
1 parent 97e2241
commit 24a0798
Showing 1 changed file with 38 additions and 30 deletions.
diff --git a/src/service/storage-local.js b/src/service/storage-local.js
@@ -13,36 +13,44 @@ angular.module('pascalprecht.translate')
 .factory('$translateLocalStorage', ['$window', '$translateCookieStorage', function ($window, $translateCookieStorage) {
 
   // Setup adapter
-  var localStorageAdapter = {
-    /**
-     * @ngdoc function
-     * @name pascalprecht.translate.$translateLocalStorage#get
-     * @methodOf pascalprecht.translate.$translateLocalStorage
-     *
-     * @description
-     * Returns an item from localStorage by given name.
-     *
-     * @param {string} name Item name
-     * @return {string} Value of item name
-     */
-    get: function (name) {
-      return $window.localStorage.getItem(name);
-    },
-    /**
-     * @ngdoc function
-     * @name pascalprecht.translate.$translateLocalStorage#set
-     * @methodOf pascalprecht.translate.$translateLocalStorage
-     *
-     * @description
-     * Sets an item in localStorage by given name.
-     *
-     * @param {string} name Item name
-     * @param {string} value Item value
-     */
-    set: function (name, value) {
-      $window.localStorage.setItem(name, value);
-    }
-  };
+  var localStorageAdapter = (function(){
+    var langKey;
+    return {
+      /**
+       * @ngdoc function
+       * @name pascalprecht.translate.$translateLocalStorage#get
+       * @methodOf pascalprecht.translate.$translateLocalStorage
+       *
+       * @description
+       * Returns an item from localStorage by given name.
+       *
+       * @param {string} name Item name
+       * @return {string} Value of item name
+       */
+      get: function (name) {
+        if(!langKey) {
+          langKey = $window.localStorage.getItem(name);
+        }
+
+        return langKey;
+      },
+      /**
+       * @ngdoc function
+       * @name pascalprecht.translate.$translateLocalStorage#set
+       * @methodOf pascalprecht.translate.$translateLocalStorage
+       *
+       * @description
+       * Sets an item in localStorage by given name.
+       *
+       * @param {string} name Item name
+       * @param {string} value Item value
+       */
+      set: function (name, value) {
+        langKey=value;
+        $window.localStorage.setItem(name, value);
+      }
+    };
+  }());
 
   var $translateLocalStorage = ('localStorage' in $window && $window.localStorage !== null) ?
   localStorageAdapter : $translateCookieStorage;