prevent setAssets from modifying original externals array

renarsvilnis · Apr 4, 2019 · 4efe03f · 4efe03f
1 parent cbc9e1b
commit 4efe03f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -327,7 +327,7 @@ var OfflinePlugin = (function () {
 
       var excludes = this.options.excludes;
       var assets = Object.keys(compilation.assets);
-      var externals = this.options.externals;
+      var externals = this.options.externals.slice();
 
       if (Array.isArray(excludes) && excludes.length) {
         assets = assets.filter(function (asset) {

diff --git a/src/index.js b/src/index.js
@@ -339,7 +339,7 @@ export default class OfflinePlugin {
 
     const excludes = this.options.excludes;
     let assets = Object.keys(compilation.assets);
-    let externals = this.options.externals;
+    let externals = this.options.externals.slice();
 
     if (Array.isArray(excludes) && excludes.length) {
       assets = assets.filter((asset) => {