chore: 🤖 upgrade sass-loader,use the sass implementation direct

renoanzhou · Nov 14, 2022 · ea9777b · ea9777b
1 parent cf71780
commit ea9777b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 18 deletions.
diff --git a/packages/xgplayer/package.json b/packages/xgplayer/package.json
@@ -57,11 +57,11 @@
         "core-js": "^2.5.4",
         "css-loader": "^0.28.11",
         "json-loader": "^0.5.7",
-        "node-sass": "^4.8.3",
         "postcss-cssnext": "^3.1.0",
         "postcss-loader": "^2.1.5",
         "raw-loader": "^2.0.0",
-        "sass-loader": "^6.0.7",
+        "sass": "^1.56.1",
+        "sass-loader": "^10.3.1",
         "style-loader": "^0.20.3",
         "sugarss": "^1.0.1",
         "uglifyjs-webpack-plugin": "^2.2.0",

diff --git a/packages/xgplayer/webpack.config.js b/packages/xgplayer/webpack.config.js
@@ -16,35 +16,40 @@ const rules = [{
       }
     },
     'postcss-loader',
-    'sass-loader'
+    {
+      loader: 'sass-loader',
+      options: {
+        implementation: require('sass')
+      }
+    }
   ]
 }, {
   test: /\.svg/,
   loader: 'raw-loader'
-}];
+}]
 
 const umdModuleConfig = {
   rules
-};
+}
 
 const babelModuleConfig = {
   rules: rules.concat({
-    test:/\.(js|jsx)$/,
-    use:{
-      loader:'babel-loader',
-      options:{
-        presets:[
+    test: /\.(js|jsx)$/,
+    use: {
+      loader: 'babel-loader',
+      options: {
+        presets: [
           'es2015'
         ],
         plugins: [
-          "add-module-exports",
-          "babel-plugin-bulk-import"
+          'add-module-exports',
+          'babel-plugin-bulk-import'
         ]
       }
     },
-    exclude:/node_modules/
+    exclude: /node_modules/
   })
-};
+}
 
 const umd = {
   entry: {
@@ -107,10 +112,10 @@ const client = {
   }
 }
 
-const controls = ['airplay', 'cssFullscreen', 'danmu', 'definition', 'download', 'enter', 'error', 'errorRetry', 
-  'flex', 'fullscreen', 'i18n', 'keyboard', 'loading', 'localPreview', 'memoryPlay', 'miniplayer', 'mobile', 'pc', 
-  'pip', 'play', 'playbackRate', 'playNext', 'poster', 'progress', 'reload', 'replay', 'rotate', 'screenShot', 
-  'start', 'textTrack', 'nativeTextTrack', 'time', 'volume'];
+const controls = ['airplay', 'cssFullscreen', 'danmu', 'definition', 'download', 'enter', 'error', 'errorRetry',
+  'flex', 'fullscreen', 'i18n', 'keyboard', 'loading', 'localPreview', 'memoryPlay', 'miniplayer', 'mobile', 'pc',
+  'pip', 'play', 'playbackRate', 'playNext', 'poster', 'progress', 'reload', 'replay', 'rotate', 'screenShot',
+  'start', 'textTrack', 'nativeTextTrack', 'time', 'volume']
 
 const umd_es6_controls = controls.map(key => {
   return {