Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Basic Scrolling in Tab Menu #3

Closed
wants to merge 14 commits into from
+220 −47
Closed

feat: Basic Scrolling in Tab Menu #3

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2827675
feat: scrolling ui line
bennjii May 23, 2023
856d437
feat: scrolling with chevrons + click to focus
bennjii May 23, 2023
277b716
mod: cleanup
bennjii May 23, 2023
3655053
mod: cargo fmt
bennjii May 24, 2023
0808cd4
mod: checks
bennjii May 24, 2023
ffeb56f
feat: hide/show icons based on scroll type [right not positioned]
bennjii Jun 1, 2023
26c163f
wip: split filled layout
bennjii Jun 2, 2023
1eba301
wip: prev w/ clippy
bennjii Jun 2, 2023
67e904d
mod: working version
bennjii Jun 2, 2023
c7d1064
mod: without slide-in
bennjii Jun 2, 2023
bee4b33
mod: constantification~
bennjii Jun 2, 2023
c41b7d2
feat: right hand icon dissapear
bennjii Jun 2, 2023
ccd4885
mod: clippy
bennjii Jun 2, 2023
badf4dc
mod: late formatting changes :)
bennjii Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mod: without slide-in
  • Loading branch information
@bennjii
bennjii committed Jun 2, 2023
commit c7d10642accf0b3eaaace21336b96c9b177646ae
15 changes: 8 additions & 7 deletions src/container/tabs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ struct ScrollState {
pub consumed: Vec2,
pub available: Vec2,
pub offset_delta: Vec2,

pub prev_frame_left: bool,
pub prev_frame_right: bool
}
Expand Down Expand Up @@ -137,20 +137,21 @@ impl Tabs {

ui.set_clip_rect(ui.available_rect_before_wrap()); // Don't cover the `rtl_ui` buttons.

println!("{} {}", scroll_state.offset.x, scroll_state.prev_frame_left);

let mut consume = ui.available_width();

if scroll_state.offset.x > 20.0 {
// if !scroll_state.prev_frame_left {
// scroll_state.offset_delta.x -= 20.0;
// }
if !scroll_state.prev_frame_left {
scroll_state.offset_delta.x += 20.0;
}

scroll_state.prev_frame_left = true;

consume -= 20.0;
}else if scroll_state.offset.x > 0.0 {
consume -= scroll_state.offset.x;
if scroll_state.prev_frame_left {
scroll_state.offset.x -= 20.0;
}
// consume -= scroll_state.offset.x;
}else {
scroll_state.prev_frame_left = false;
}
Expand Down