-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend coral plant blocktags #1047
Conversation
These tags don't exist in vanilla, not even in snapshots, why should we add them? |
I added the dead states because of falses in Grim due to dead coral not being modeled as coral with the same hitboxes. I figured someone somewhere would still want the old behavior of only getting alive coral and dead coral. The important thing is to add the dead coral to the corals blocktag. I wasn't aware blocktags were just ports off a vanilla feature. I'll delete the new tags and just leave this PR to add the dead corals to the coral tags if you're insistent on it. |
you can still add them, just move them to the bottom of the class - packetevents already has some "inofficial"/"legacy" block tags everything above the comments is auto-generated and will be replaced with the next version update i'm also planning on re-designing the item/block tags, as they no longer represent vanilla's tags properly |
I'm not sure exactly where you mean by bottom of the class. At the end of the entries or at the actual bottom below the code? what about adding entries to the blocktag? |
See how GLASS_BLOCKS or GLASS_PANES are defined |
Fixed @booky10 |
...main/java/com/github/retrooper/packetevents/protocol/world/states/defaulttags/BlockTags.java
Outdated
Show resolved
Hide resolved
…AL_PLANTS blocktags
Also add new ALIVE_CORAL_PLANTS and DEAD_CORAL_PLANTS blocktags