Fix CSRF #88
Merged
Fix CSRF #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for looking into it. I assume by google http server you mean the go http server module of revel. Wouldn't it make sense to fix this in the http server module? Otherwise each filter needs to fix this itself? And what about apps that for some reason want the request url? |
|
No I mean the Go http server, it is not a bug in Revel. see |
|
Ok, but still, wouldn't it make sense to fix this in revel for all modules, instead of separately in each module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The google http server does not fully populate the Request.URL so this check fails.
I added code to populate the Request.URL fully
closes #83