return default in get_column_values if no execute (dbt-labs#386)

* return default in get_column_values if no execute * Update CHANGELOG.md * Update macros/sql/get_column_values.sql Co-authored-by: Jason Ganz <[email protected]> * Update require-dbt-version Co-authored-by: Joel Labes <[email protected]> Co-authored-by: Jason Ganz <[email protected]>
rfeith2 · Nov 11, 2021 · 2ed471b · 2ed471b
1 parent 296de1f
commit 2ed471b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -102,6 +102,7 @@ If you were relying on the position to match up your optional arguments, this ma
 ## Under the hood
 * Update the default implementation of concat macro to use `||` operator ([#373](https://github.com/fishtown-analytics/dbt-utils/pull/314) from [@ChristopheDuong](https://github.com/ChristopheDuong)). Note this may be a breaking change for adapters that support `concat()` but not `||`, such as Apache Spark.
 - Use `power()` instead of `pow()` in `generate_series()` and `haversine_distance()` as they are synonyms in most SQL dialects, but some dialects only have `power()` ([#354](https://github.com/fishtown-analytics/dbt-utils/pull/354) from [@swanderz](https://github.com/swanderz))
+- Make `get_column_values` return the default value passed as a parameter instead of an empty string before compilation ([#304](https://github.com/dbt-labs/dbt-utils/pull/386) from [@jmriego](https://github.com/jmriego)
 
 # dbt-utils v0.6.6
 

diff --git a/macros/sql/get_column_values.sql b/macros/sql/get_column_values.sql
@@ -3,10 +3,12 @@
 {% endmacro %}
 
 {% macro default__get_column_values(table, column, order_by='count(*) desc', max_records=none, default=none) -%}
-
+{% if default is none %}
+    {% set default = [] %}
+{% endif %}
     {#-- Prevent querying of db in parsing mode. This works because this macro does not create any new refs. #}
     {%- if not execute -%}
-        {{ return('') }}
+        {{ return(default) }}
     {% endif %}
 
     {%- set target_relation = adapter.get_relation(database=table.database,