Skip to content

Commit

Permalink
Add "resolve_wishlist_items_from_user"
Browse files Browse the repository at this point in the history
to suppress the "unused root/user argument"
  • Loading branch information
derenio committed Dec 17, 2019
1 parent 8277181 commit 5fa81e8
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 13 deletions.
4 changes: 2 additions & 2 deletions saleor/graphql/account/types.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ..core.utils import get_node_optimized
from ..decorators import one_of_permissions_required
from ..utils import format_permissions_for_display
from ..wishlist.resolvers import resolve_wishlist_items_from_info
from ..wishlist.resolvers import resolve_wishlist_items_from_user
from ..wishlist.types import WishlistItem
from .enums import CountryCodeEnum, CustomerEventsEnum

Expand Down Expand Up @@ -357,7 +357,7 @@ def resolve_meta(root, _info):

@staticmethod
def resolve_wishlist(root: models.User, info, **_kwargs):
return resolve_wishlist_items_from_info(info)
return resolve_wishlist_items_from_user(root)

@staticmethod
def __resolve_reference(root, _info, **_kwargs):
Expand Down
23 changes: 12 additions & 11 deletions saleor/graphql/wishlist/resolvers.py
Original file line number Diff line number Diff line change
@@ -1,25 +1,26 @@
from typing import TYPE_CHECKING, List

from graphql_jwt.decorators import login_required

from ...wishlist.models import Wishlist, WishlistItem
from ...wishlist.models import Wishlist

if TYPE_CHECKING:
# flake8: noqa
# pylint: disable=unused-import
from graphene.types import ResolveInfo
from ...account.models import User


@login_required
def resolve_wishlist_from_info(info: "ResolveInfo") -> Wishlist:
def resolve_wishlist_from_user(user: "User") -> Wishlist:
"""Return wishlist of the logged in user."""
user = info.context.user
return Wishlist.objects.get_or_create(user)
wishlist = Wishlist.objects.get_or_create(user)
return wishlist


@login_required
def resolve_wishlist_items_from_info(info: "ResolveInfo") -> List[WishlistItem]:
def resolve_wishlist_from_info(info: "ResolveInfo") -> Wishlist:
"""Return wishlist of the logged in user."""
user = info.context.user
wishlist = Wishlist.objects.get_or_create(user)
return resolve_wishlist_from_user(user)


def resolve_wishlist_items_from_user(user: "User") -> List[Wishlist]:
"""Return wishlist items of the logged in user."""
wishlist = resolve_wishlist_from_user(user)
return wishlist.items.all()

0 comments on commit 5fa81e8

Please sign in to comment.