fixes #39 - corrects signature_hash for SIGHASH_SINGLE on input index > 0; ... #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… > 0; adds ability to verify legacy SINGLE_HASH transactions; adds TxIn to tx/__init__.py for consistency with Tx and TxOut
…oin_streamer, but "fakes" the "null" value of -1L by using its unsigned equivalent instead)
|
Do you know of any test transactions in the blockchain that I can include in test cases? |
richardkiss
added a commit
that referenced
this pull request
Jun 5, 2014
fixes #39 - corrects signature_hash for SIGHASH_SINGLE on input index > 0; ...
|
Oh, I see you put some in, great! Thanks so much! |
|
Yeah, those were contrived cases. These might help (as a battery of various transaction verifications): https://github.com/bitcoin/bitcoin/blob/master/src/test/data/tx_valid.json#L39 (see also line 96) I'd have to think about how to incorporate all of these into your unit tests. This may be beyond the scope of this pull request, and deserving of its own issue? I have not independently verified this, but this bitcointalk.org post claims to cite three in-blockchain transactions with SIGHASH_SINGLE signatures where nIn > nOut (i.e., the old, buggy code path): |
richardkiss
added a commit
that referenced
this pull request
Nov 24, 2014
ghtdak
pushed a commit
to ghtdak/pycoin
that referenced
this pull request
Jul 16, 2016
fixes richardkiss#39 - corrects signature_hash for SIGHASH_SINGLE on input index > 0; ... [gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:50:46 2016] [from commit: 762fc89]
ghtdak
pushed a commit
to ghtdak/pycoin
that referenced
this pull request
Jul 16, 2016
[gitreformat yapf-ify (github/ghtdak) on Fri Jul 15 12:51:26 2016] [from commit: c89f3d8]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...adds ability to verify legacy SINGLE_HASH transactions; adds TxIn to tx/init.py for consistency with Tx and TxOut
Hopefully this fix for issue #39 helps redeem me from the utter embarrassment that is issue #38. :o(
I wrote a test script to compare the fixed output of
pycoinwith the equivalent output frombitcoinj. The python half is adapted as a (now working) unit test in e8b026f.On a related note, your
BRAIN DAMAGE: this probably doesn't work rightcomment was wrong...that part of the code was fine. It just required a number encoding tweak.... :o)