Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to allow using multiple gpus with default configuration #19

Closed
wants to merge 1 commit into from

Conversation

g1910
Copy link

@g1910 g1910 commented Jan 26, 2019

Hi, I have made changes to the repository to allow using multiple GPUs with Perceptual Similarity implementation. Please review and let me know of any further changes.

@richzhang
Copy link
Owner

richzhang commented Jul 20, 2019

Thank you very much for the pull request. I used it as guidance to add parallelization to the latest commit. I also realized that the PNetLin doesn't need the gpu id information itself and its gpu placement should be controlled from the DistModel class above

@g1910
Copy link
Author

g1910 commented Jul 21, 2019

Hi Richard, thanks for incorporating the changes. I would have appreciated if you had merged my pull request directly into the code base or suggested further changes for merge so that my contribution could have been officially acknowledged. Since you went ahead and made the changes yourself, it would be nice if you could please acknowledge my contribution somewhere in the repository (perhaps in the ReadMe).

@richzhang
Copy link
Owner

I got around to cleaning things up and made a pip install. I added you to the readme

@richzhang richzhang closed this Sep 7, 2020
@g1910
Copy link
Author

g1910 commented Sep 10, 2020

Thanks @richzhang! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants