Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging #40

Closed
wants to merge 6 commits into from
Closed

Packaging #40

wants to merge 6 commits into from

Conversation

wilhelmhb
Copy link

Allow the PerceptualLoss to be installed as a package, and reused.
#39 forces us to call python setup.py.
#13 has not been updated for more than a year.

The package will include the README and the weights.

I also fixed some dependencies, and cleaned a part of the code.

@mameli
Copy link

mameli commented Dec 5, 2019

As long as the author has not indexed the package in PyPI, isn't the command python setup.py install the easiest way to install this repo? pip install perceptual-similarity-pytorch is not working right now
p.s. Good job on the code refactoring

@wilhelmhb
Copy link
Author

pip install perceptual-similarity-pytorch is the command for installing the package once it has been published to PyPI.
The easiest way to install this repo is pip install -e /path/to/repo, from anywhere else. The -eoptions will reflect changes from the source code, thus you should not need to reinstall the repo each time you change something.

@smsegal
Copy link

smsegal commented Jun 16, 2020

@wilhelmhb Oh darn I just redid a bunch of this packaging work on my own, I should have checked the PR's first. You haven't published to PyPi correct? I'll just be installing this from your fork then.

@wilhelmhb
Copy link
Author

wilhelmhb commented Jun 17, 2020

@smsegal no, I haven't published to PyPi. I wanted to let the owner of the original repo do it, as it's not my own code ;)

Glad my contribution is useful to someone =)

@richzhang
Copy link
Owner

I finally got around to making a pip install. Thanks for your PR; I added you to the readme

@richzhang richzhang closed this Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants