forked from rerun-io/rerun
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
New PR template + associated CI updates (rerun-io#8192)
### What - [x] Greatly simplify the PR template - [x] Nuke PR summary - [x] Simplify `paths-filter` in PR CI, so that we don't start N machines for N filters - [x] Checkboxes in PR body are now optional, but still checked if present - [x] Web build status comment - [x] First-time contributor comments - [x] Add an index page to https://build.rerun.io - [x] 👽 --------- Co-authored-by: Emil Ernerfeldt <[email protected]>
- Loading branch information
Showing
15 changed files
with
156 additions
and
610 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,31 +1,22 @@ | ||
| <!-- | ||
| Open the PR up as a draft until you feel it is ready for a proper review. | ||
| Do not make PR:s from your own `main` branch, as that makes it difficult for reviewers to add their own fixes. | ||
| Add any improvements to the branch as new commits to make it easier for reviewers to follow the progress. All commits will be squashed to a single commit once the PR is merged into `main`. | ||
| Make sure you mention any issues that this PR closes in the description, as well as any other related issues. | ||
| ### Related | ||
|
|
||
| To get an auto-generated PR description you can put "copilot:summary" or "copilot:walkthrough" anywhere. | ||
| <!-- | ||
| Include links to any related issues/PRs in a bulleted list, for example: | ||
| * Closes #1234 | ||
| * Part of #1337 | ||
| --> | ||
|
|
||
| ### What | ||
|
|
||
| ### Checklist | ||
| * [ ] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) | ||
| * [ ] I've included a screenshot or gif (if applicable) | ||
| * [ ] I have tested the web demo (if applicable): | ||
| * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) | ||
| * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/{{pr.number}}?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) | ||
| * [ ] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG | ||
| * [ ] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! | ||
| * [ ] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide | ||
| <!-- | ||
| Make sure the PR title and labels are set to maximize their usefulness for the CHANGELOG, | ||
| and our `git log`. | ||
| - [PR Build Summary](https://build.rerun.io/pr/{{pr.number}}) | ||
| - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) | ||
| - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) | ||
| If you have noticed any breaking changes, include them in the migration guide. | ||
| To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. | ||
| We track various metrics at <https://build.rerun.io>. | ||
| To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. | ||
| For maintainers: | ||
| * To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. | ||
| * To deploy documentation changes immediately after merging this PR, add the `deploy docs` label. | ||
| --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| name: First time contributors | ||
|
|
||
| on: | ||
| pull_request_target: | ||
|
|
||
| permissions: | ||
| contents: "write" | ||
| id-token: "write" | ||
| pull-requests: "write" | ||
|
|
||
| jobs: | ||
| comment: | ||
| name: Comment on PRs | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| pr-message: | | ||
| Hi! Thanks for opening this pull request. | ||
| Because this is your first time contributing to this repository, make sure you've read our [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.