Skip to content

Commit

Permalink
Fix video simple snippet (2) (rerun-io#7315)
Browse files Browse the repository at this point in the history
### What

There was another ancient copy-pasta mistake where the `MediaType` was
being set to `glb` for `video/mp4`...

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7315?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7315?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7315)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
  • Loading branch information
jprochazk authored Aug 29, 2024
1 parent a57c3ed commit c6dcfb7
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/archetypes/asset_video_ext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ namespace rerun::archetypes {
std::transform(ext.begin(), ext.end(), ext.begin(), ::tolower);

if (ext == ".mp4") {
return rerun::components::MediaType::glb();
return rerun::components::MediaType::mp4();
} else {
return std::nullopt;
}
Expand Down
7 changes: 7 additions & 0 deletions rerun_cpp/src/rerun/components/media_type.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c6dcfb7

Please sign in to comment.