Skip to content

Commit

Permalink
Run GH Actions with Node v18 for fetch support (#35)
Browse files Browse the repository at this point in the history
Running the tests on Node v18 fixes issues where Jest complains about
missing globals like Request/Response/Headers that are always available in
Remix environments so it's ok to just run the test on 18 intead of 16.
  • Loading branch information
rileytomasek authored Aug 5, 2023
1 parent 033031b commit 93276a8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn lint
Expand All @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn test
Expand All @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 18
cache: 'yarn'
- run: yarn install --frozen-lockfile
- run: yarn typecheck

0 comments on commit 93276a8

Please sign in to comment.