Declare compatibility with Guzzle v7 #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked all the (few) places where oauth1 calls Guzzle APIs and they should still work. Also none of the items in the [upgrading guide](https://github.com/guzzle/guzzle/blob/7.0.0/UPGRADING.md#60-to-70) seem applicable. The [native function calls](https://github.com/guzzle/guzzle/blob/7.0.0/UPGRADING.md#native-functions-calls) change and the [booleans change](https://github.com/guzzle/psr7/blob/2.0.0/CHANGELOG.md#200beta-1---2021-03-21) in guzzle/psr7 might be breaking for some users of oauth1, but I'm not sure if oauth1 needs a major release due to this, as users are free to keep using the old Guzzle versions.
|
@risan It would be great if this could be merged and released. Security patch maintenance for Guzzle v6 end in half a year, and folks may need some time to get updates deployed. |
|
Hi @risan ! Any updates for this? That would be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked all the (few) places where oauth1 calls Guzzle APIs and they should still work. Also none of the items in the upgrading guide seem applicable. The native function calls change and the booleans change in guzzle/psr7 might be breaking for some users of oauth1, but I'm not sure if oauth1 needs a major release due to this, as users are free to keep using the old Guzzle versions.