Skip to content

Commit

Permalink
[build] Add lots of headers missing from BUILD.gn
Browse files Browse the repository at this point in the history
Unfortunately GN check does not detect missing dependencies for headers
that don't appear in any build rule, so it failed to report that these
headers are not referenced at all.

Bug: v8:7330
Change-Id: I5d11467f322e5497f2d952f734bc69ccf0896bfe
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3032082
Auto-Submit: Dan Elphick <[email protected]>
Commit-Queue: Ross McIlroy <[email protected]>
Reviewed-by: Ross McIlroy <[email protected]>
Cr-Commit-Position: refs/heads/master@{#75744}
  • Loading branch information
danelphick authored and V8 LUCI CQ committed Jul 15, 2021
1 parent 485c15c commit 6794c6d
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -2114,6 +2114,7 @@ v8_source_set("v8_initializers") {
"src/builtins/builtins-call-gen.cc",
"src/builtins/builtins-call-gen.h",
"src/builtins/builtins-collections-gen.cc",
"src/builtins/builtins-collections-gen.h",
"src/builtins/builtins-constructor-gen.cc",
"src/builtins/builtins-constructor-gen.h",
"src/builtins/builtins-constructor.h",
Expand Down Expand Up @@ -2475,6 +2476,9 @@ v8_header_set("v8_internal_headers") {
"src/common/ptr-compr.h",
"src/compiler-dispatcher/compiler-dispatcher.h",
"src/compiler-dispatcher/optimizing-compile-dispatcher.h",
"src/compiler/access-builder.h",
"src/compiler/access-info.h",
"src/compiler/add-type-assertions-reducer.h",
"src/compiler/all-nodes.h",
"src/compiler/allocation-builder-inl.h",
"src/compiler/allocation-builder.h",
Expand Down Expand Up @@ -2530,6 +2534,7 @@ v8_header_set("v8_internal_headers") {
"src/compiler/graph-visualizer.h",
"src/compiler/graph-zone-traits.h",
"src/compiler/graph.h",
"src/compiler/heap-refs.h",
"src/compiler/js-call-reducer.h",
"src/compiler/js-context-specialization.h",
"src/compiler/js-create-lowering.h",
Expand Down Expand Up @@ -2696,6 +2701,7 @@ v8_header_set("v8_internal_headers") {
"src/heap/cppgc-js/unified-heap-marking-verifier.h",
"src/heap/cppgc-js/unified-heap-marking-visitor.h",
"src/heap/embedder-tracing.h",
"src/heap/factory-base-inl.h",
"src/heap/factory-base.h",
"src/heap/factory-inl.h",
"src/heap/factory.h",
Expand Down Expand Up @@ -2873,6 +2879,7 @@ v8_header_set("v8_internal_headers") {
"src/objects/free-space-inl.h",
"src/objects/free-space.h",
"src/objects/function-kind.h",
"src/objects/function-syntax-kind.h",
"src/objects/hash-table-inl.h",
"src/objects/hash-table.h",
"src/objects/heap-number-inl.h",
Expand Down Expand Up @@ -2935,6 +2942,7 @@ v8_header_set("v8_internal_headers") {
"src/objects/object-type.h",
"src/objects/objects-body-descriptors-inl.h",
"src/objects/objects-body-descriptors.h",
"src/objects/objects-definitions.h",
"src/objects/objects-inl.h",
"src/objects/objects.h",
"src/objects/oddball-inl.h",
Expand Down Expand Up @@ -2970,6 +2978,8 @@ v8_header_set("v8_internal_headers") {
"src/objects/slots-atomic-inl.h",
"src/objects/slots-inl.h",
"src/objects/slots.h",
"src/objects/smi-inl.h",
"src/objects/smi.h",
"src/objects/source-text-module-inl.h",
"src/objects/source-text-module.h",
"src/objects/stack-frame-info-inl.h",
Expand Down Expand Up @@ -3150,6 +3160,7 @@ v8_header_set("v8_internal_headers") {
if (v8_enable_webassembly) {
sources += [
"src/asmjs/asm-js.h",
"src/asmjs/asm-names.h",
"src/asmjs/asm-parser.h",
"src/asmjs/asm-scanner.h",
"src/asmjs/asm-types.h",
Expand Down Expand Up @@ -4713,6 +4724,7 @@ v8_component("v8_libbase") {
"src/base/sys-info.cc",
"src/base/sys-info.h",
"src/base/template-utils.h",
"src/base/threaded-list.h",
"src/base/timezone-cache.h",
"src/base/type-traits.h",
"src/base/utils/random-number-generator.cc",
Expand Down

0 comments on commit 6794c6d

Please sign in to comment.