Debug: Use the --32 and --64 command line arguments #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsifive
approved these changes
Nov 7, 2017
debug/targets.py
Outdated
| if (h.xlen == 0): | ||
| h.xlen = parsed.xlen | ||
| elif (h.xlen != parsed.xlen): | ||
| raise Exception("Hart had a specified XLEN of %d and target had a specified XLEN of %d, they must match." % (h.xlen, parsed.xlen)) |
There was a problem hiding this comment.
Originally this option would allow you to override XLEN as well. Given that changing XLEN often requires a new link map I don't know how useful that really was, so I'm fine with this new requirement.
I'd say this instead:
"The target has an XLEN of %d, but the command line specified an XLEN of %d. They must match."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #96, but I'm not sure this is the change that makes sense.