forked from tensorflow/models
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update DRAGNN, fix some macOS issues
- Loading branch information
Ivan Bogatyy
committed
Mar 23, 2017
1 parent
b7523ee
commit ea3fa4a
Showing
115 changed files
with
3,527 additions
and
192 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package( | ||
default_visibility = ["//visibility:public"], | ||
features = ["-layering_check"], | ||
) | ||
|
||
cc_library( | ||
name = "stateless_component", | ||
srcs = ["stateless_component.cc"], | ||
deps = [ | ||
"//dragnn/core:component_registry", | ||
"//dragnn/core/interfaces:component", | ||
"//dragnn/core/interfaces:transition_state", | ||
"//dragnn/io:sentence_input_batch", | ||
"//dragnn/protos:data_proto", | ||
"//syntaxnet:base", | ||
], | ||
alwayslink = 1, | ||
) | ||
|
||
cc_test( | ||
name = "stateless_component_test", | ||
srcs = ["stateless_component_test.cc"], | ||
deps = [ | ||
":stateless_component", | ||
"//dragnn/core:component_registry", | ||
"//dragnn/core:input_batch_cache", | ||
"//dragnn/core/test:generic", | ||
"//dragnn/core/test:mock_transition_state", | ||
"//dragnn/io:sentence_input_batch", | ||
"//syntaxnet:base", | ||
"//syntaxnet:sentence_proto", | ||
"//syntaxnet:test_main", | ||
], | ||
) |
131 changes: 131 additions & 0 deletions
131
syntaxnet/dragnn/components/stateless/stateless_component.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,131 @@ | ||
// Copyright 2017 Google Inc. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// ============================================================================= | ||
|
||
#include "dragnn/core/component_registry.h" | ||
#include "dragnn/core/interfaces/component.h" | ||
#include "dragnn/core/interfaces/transition_state.h" | ||
#include "dragnn/io/sentence_input_batch.h" | ||
#include "dragnn/protos/data.pb.h" | ||
#include "syntaxnet/base.h" | ||
|
||
namespace syntaxnet { | ||
namespace dragnn { | ||
namespace { | ||
|
||
// A component that does not create its own transition states; instead, it | ||
// simply forwards the states of the previous component. Does not support all | ||
// methods. Intended for "compute-only" bulk components that only use linked | ||
// features, which use only a small subset of DRAGNN functionality. | ||
class StatelessComponent : public Component { | ||
public: | ||
void InitializeComponent(const ComponentSpec &spec) override { | ||
name_ = spec.name(); | ||
} | ||
|
||
// Stores the |parent_states| for forwarding to downstream components. | ||
void InitializeData( | ||
const std::vector<std::vector<const TransitionState *>> &parent_states, | ||
int max_beam_size, InputBatchCache *input_data) override { | ||
// Must use SentenceInputBatch to match SyntaxNetComponent. | ||
batch_size_ = input_data->GetAs<SentenceInputBatch>()->data()->size(); | ||
beam_size_ = max_beam_size; | ||
parent_states_ = parent_states; | ||
|
||
// The beam should be wide enough for the previous component. | ||
for (const auto &beam : parent_states) { | ||
CHECK_LE(beam.size(), beam_size_); | ||
} | ||
} | ||
|
||
// Forwards the states of the previous component. | ||
std::vector<std::vector<const TransitionState *>> GetBeam() override { | ||
return parent_states_; | ||
} | ||
|
||
// Forwards the |current_index| to the previous component. | ||
int GetSourceBeamIndex(int current_index, int batch) const override { | ||
return current_index; | ||
} | ||
|
||
string Name() const override { return name_; } | ||
int BeamSize() const override { return beam_size_; } | ||
int BatchSize() const override { return batch_size_; } | ||
int StepsTaken(int batch_index) const override { return 0; } | ||
bool IsReady() const override { return true; } | ||
bool IsTerminal() const override { return true; } | ||
void FinalizeData() override {} | ||
void ResetComponent() override {} | ||
void InitializeTracing() override {} | ||
void DisableTracing() override {} | ||
std::vector<std::vector<ComponentTrace>> GetTraceProtos() const override { | ||
return {}; | ||
} | ||
|
||
// Unsupported methods. | ||
int GetBeamIndexAtStep(int step, int current_index, | ||
int batch) const override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return 0; | ||
} | ||
std::function<int(int, int, int)> GetStepLookupFunction( | ||
const string &method) override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return nullptr; | ||
} | ||
void AdvanceFromPrediction(const float transition_matrix[], | ||
int matrix_length) override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
} | ||
void AdvanceFromOracle() override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
} | ||
std::vector<std::vector<int>> GetOracleLabels() const override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return {}; | ||
} | ||
int GetFixedFeatures(std::function<int32 *(int)> allocate_indices, | ||
std::function<int64 *(int)> allocate_ids, | ||
std::function<float *(int)> allocate_weights, | ||
int channel_id) const override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return 0; | ||
} | ||
int BulkGetFixedFeatures(const BulkFeatureExtractor &extractor) override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return 0; | ||
} | ||
std::vector<LinkFeatures> GetRawLinkFeatures(int channel_id) const override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
return {}; | ||
} | ||
void AddTranslatedLinkFeaturesToTrace( | ||
const std::vector<LinkFeatures> &features, int channel_id) override { | ||
LOG(FATAL) << "[" << name_ << "] Method not supported"; | ||
} | ||
|
||
private: | ||
string name_; // component name | ||
int batch_size_ = 1; // number of sentences in current batch | ||
int beam_size_ = 1; // maximum beam size | ||
|
||
// Parent states passed to InitializeData(), and passed along in GetBeam(). | ||
std::vector<std::vector<const TransitionState *>> parent_states_; | ||
}; | ||
|
||
REGISTER_DRAGNN_COMPONENT(StatelessComponent); | ||
|
||
} // namespace | ||
} // namespace dragnn | ||
} // namespace syntaxnet |
171 changes: 171 additions & 0 deletions
171
syntaxnet/dragnn/components/stateless/stateless_component_test.cc
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,171 @@ | ||
// Copyright 2017 Google Inc. All Rights Reserved. | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
// ============================================================================= | ||
|
||
#include "dragnn/core/component_registry.h" | ||
#include "dragnn/core/input_batch_cache.h" | ||
#include "dragnn/core/test/generic.h" | ||
#include "dragnn/core/test/mock_transition_state.h" | ||
#include "dragnn/io/sentence_input_batch.h" | ||
#include "syntaxnet/base.h" | ||
#include "syntaxnet/sentence.pb.h" | ||
#include "tensorflow/core/lib/core/errors.h" | ||
#include "tensorflow/core/lib/core/status.h" | ||
#include "tensorflow/core/lib/io/path.h" | ||
#include "tensorflow/core/platform/env.h" | ||
#include "tensorflow/core/platform/protobuf.h" | ||
#include "tensorflow/core/platform/test.h" | ||
|
||
namespace syntaxnet { | ||
namespace dragnn { | ||
namespace { | ||
|
||
const char kSentence0[] = R"( | ||
token { | ||
word: "Sentence" start: 0 end: 7 tag: "NN" category: "NOUN" label: "ROOT" | ||
break_level: NO_BREAK | ||
} | ||
token { | ||
word: "0" start: 9 end: 9 head: 0 tag: "CD" category: "NUM" label: "num" | ||
break_level: SPACE_BREAK | ||
} | ||
token { | ||
word: "." start: 10 end: 10 head: 0 tag: "." category: "." label: "punct" | ||
break_level: NO_BREAK | ||
} | ||
)"; | ||
|
||
const char kSentence1[] = R"( | ||
token { | ||
word: "Sentence" start: 0 end: 7 tag: "NN" category: "NOUN" label: "ROOT" | ||
break_level: NO_BREAK | ||
} | ||
token { | ||
word: "1" start: 9 end: 9 head: 0 tag: "CD" category: "NUM" label: "num" | ||
break_level: SPACE_BREAK | ||
} | ||
token { | ||
word: "." start: 10 end: 10 head: 0 tag: "." category: "." label: "punct" | ||
break_level: NO_BREAK | ||
} | ||
)"; | ||
|
||
const char kLongSentence[] = R"( | ||
token { | ||
word: "Sentence" start: 0 end: 7 tag: "NN" category: "NOUN" label: "ROOT" | ||
break_level: NO_BREAK | ||
} | ||
token { | ||
word: "1" start: 9 end: 9 head: 0 tag: "CD" category: "NUM" label: "num" | ||
break_level: SPACE_BREAK | ||
} | ||
token { | ||
word: "2" start: 10 end: 10 head: 0 tag: "CD" category: "NUM" label: "num" | ||
break_level: SPACE_BREAK | ||
} | ||
token { | ||
word: "3" start: 11 end: 11 head: 0 tag: "CD" category: "NUM" label: "num" | ||
break_level: SPACE_BREAK | ||
} | ||
token { | ||
word: "." start: 12 end: 12 head: 0 tag: "." category: "." label: "punct" | ||
break_level: NO_BREAK | ||
} | ||
)"; | ||
|
||
const char kMasterSpec[] = R"( | ||
component { | ||
name: "test" | ||
transition_system { | ||
registered_name: "shift-only" | ||
} | ||
linked_feature { | ||
name: "prev" | ||
fml: "input.focus" | ||
embedding_dim: 32 | ||
size: 1 | ||
source_component: "prev" | ||
source_translator: "identity" | ||
source_layer: "last_layer" | ||
} | ||
backend { | ||
registered_name: "StatelessComponent" | ||
} | ||
} | ||
)"; | ||
|
||
} // namespace | ||
|
||
using testing::Return; | ||
|
||
class StatelessComponentTest : public ::testing::Test { | ||
public: | ||
std::unique_ptr<Component> CreateParser( | ||
int beam_size, | ||
const std::vector<std::vector<const TransitionState *>> &states, | ||
const std::vector<string> &data) { | ||
MasterSpec master_spec; | ||
CHECK(TextFormat::ParseFromString(kMasterSpec, &master_spec)); | ||
data_.reset(new InputBatchCache(data)); | ||
|
||
// Create a parser component with the specified beam size. | ||
std::unique_ptr<Component> parser_component( | ||
Component::Create("StatelessComponent")); | ||
parser_component->InitializeComponent(master_spec.component(0)); | ||
parser_component->InitializeData(states, beam_size, data_.get()); | ||
return parser_component; | ||
} | ||
|
||
std::unique_ptr<InputBatchCache> data_; | ||
}; | ||
|
||
TEST_F(StatelessComponentTest, ForwardsTransitionStates) { | ||
const MockTransitionState mock_state_1, mock_state_2, mock_state_3; | ||
const std::vector<std::vector<const TransitionState *>> parent_states = { | ||
{}, {&mock_state_1}, {&mock_state_2, &mock_state_3}}; | ||
|
||
std::vector<string> data; | ||
for (const string &textproto : {kSentence0, kSentence1, kLongSentence}) { | ||
Sentence sentence; | ||
CHECK(TextFormat::ParseFromString(textproto, &sentence)); | ||
data.emplace_back(); | ||
CHECK(sentence.SerializeToString(&data.back())); | ||
} | ||
CHECK_EQ(parent_states.size(), data.size()); | ||
|
||
const int kBeamSize = 2; | ||
auto test_parser = CreateParser(kBeamSize, parent_states, data); | ||
|
||
EXPECT_TRUE(test_parser->IsReady()); | ||
EXPECT_TRUE(test_parser->IsTerminal()); | ||
EXPECT_EQ(kBeamSize, test_parser->BeamSize()); | ||
EXPECT_EQ(data.size(), test_parser->BatchSize()); | ||
EXPECT_TRUE(test_parser->GetTraceProtos().empty()); | ||
|
||
for (int batch_index = 0; batch_index < parent_states.size(); ++batch_index) { | ||
EXPECT_EQ(0, test_parser->StepsTaken(batch_index)); | ||
const auto &beam = parent_states[batch_index]; | ||
for (int beam_index = 0; beam_index < beam.size(); ++beam_index) { | ||
// Expect an identity mapping. | ||
EXPECT_EQ(beam_index, | ||
test_parser->GetSourceBeamIndex(beam_index, batch_index)); | ||
} | ||
} | ||
|
||
const auto forwarded_states = test_parser->GetBeam(); | ||
EXPECT_EQ(parent_states, forwarded_states); | ||
} | ||
|
||
} // namespace dragnn | ||
} // namespace syntaxnet |
Oops, something went wrong.