Rename variable for ShapeVisitor from cases to visitor

rnihithp · May 12, 2022 · 7616173 · 7616173
1 parent 50be159
commit 7616173
Show file tree

Hide file tree

Showing 25 changed files with 81 additions and 81 deletions.
diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BigDecimalShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BigDecimalShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.bigDecimalShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.bigDecimalShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BigIntegerShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BigIntegerShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.bigIntegerShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.bigIntegerShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BlobShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BlobShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.blobShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.blobShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BooleanShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/BooleanShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.booleanShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.booleanShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ByteShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ByteShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.byteShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.byteShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/DocumentShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/DocumentShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.documentShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.documentShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/DoubleShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/DoubleShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.doubleShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.doubleShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/FloatShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/FloatShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.floatShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.floatShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/IntegerShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/IntegerShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.integerShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.integerShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ListShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ListShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.listShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.listShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/LongShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/LongShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.longShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.longShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/MapShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/MapShape.java
@@ -61,8 +61,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.mapShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.mapShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/MemberShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/MemberShape.java
@@ -55,8 +55,8 @@ public ShapeId getContainer() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.memberShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.memberShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/OperationShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/OperationShape.java
@@ -55,8 +55,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.operationShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.operationShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ResourceShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ResourceShape.java
@@ -82,8 +82,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.resourceShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.resourceShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ServiceShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ServiceShape.java
@@ -55,8 +55,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.serviceShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.serviceShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/SetShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/SetShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.setShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.setShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/Shape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/Shape.java
@@ -107,10 +107,10 @@ public static <B extends AbstractShapeBuilder<B, S>, S extends Shape> B shapeToB
      * Dispatches the shape to the appropriate {@link ShapeVisitor} method.
      *
      * @param <R> Return type of the accept.
-     * @param cases NeighborVisitor to use.
+     * @param visitor ShapeVisitor to use.
      * @return Returns the result.
      */
-    public abstract <R> R accept(ShapeVisitor<R> cases);
+    public abstract <R> R accept(ShapeVisitor<R> visitor);
 
     /**
      * Get the {@link ShapeId} of the shape.

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ShortShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/ShortShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.shortShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.shortShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/StringShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/StringShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.stringShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.stringShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/StructureShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/StructureShape.java
@@ -40,8 +40,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.structureShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.structureShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/TimestampShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/TimestampShape.java
@@ -36,8 +36,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.timestampShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.timestampShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/main/java/software/amazon/smithy/model/shapes/UnionShape.java b/smithy-model/src/main/java/software/amazon/smithy/model/shapes/UnionShape.java
@@ -37,8 +37,8 @@ public Builder toBuilder() {
     }
 
     @Override
-    public <R> R accept(ShapeVisitor<R> cases) {
-        return cases.unionShape(this);
+    public <R> R accept(ShapeVisitor<R> visitor) {
+        return visitor.unionShape(this);
     }
 
     @Override

diff --git a/smithy-model/src/test/java/software/amazon/smithy/model/shapes/ShapeVisitorDefaultTest.java b/smithy-model/src/test/java/software/amazon/smithy/model/shapes/ShapeVisitorDefaultTest.java
@@ -22,67 +22,67 @@
 public class ShapeVisitorDefaultTest {
 
     @Test
-    public void sendsCasesToDefaultValue() {
-        ShapeVisitor<Integer> cases = new ShapeVisitor.Default<Integer>() {
+    public void sendsVisitorToDefaultValue() {
+        ShapeVisitor<Integer> visitor = new ShapeVisitor.Default<Integer>() {
             @Override
             protected Integer getDefault(Shape shape) {
                 return 1;
             }
         };
 
-        testCases(cases);
+        testCases(visitor);
     }
 
-    private void testCases(ShapeVisitor<Integer> cases) {
+    private void testCases(ShapeVisitor<Integer> visitor) {
         Integer value = 1;
-        assertEquals(value, BlobShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, BooleanShape.builder().id("ns.foo#Bar").build().accept(cases));
+        assertEquals(value, BlobShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, BooleanShape.builder().id("ns.foo#Bar").build().accept(visitor));
         assertEquals(value, ListShape.builder()
                 .id("ns.foo#Bar")
                 .member(MemberShape.builder().id("ns.foo#Bar$member").target("ns.foo#Baz").build())
                 .build()
-                .accept(cases));
+                .accept(visitor));
         assertEquals(value, SetShape.builder()
                 .id("ns.foo#Bar")
                 .member(MemberShape.builder().id("ns.foo#Bar$member").target("ns.foo#Baz").build())
                 .build()
-                .accept(cases));
+                .accept(visitor));
         assertEquals(value, MapShape.builder()
                 .id("ns.foo#Bar")
                 .key(MemberShape.builder().id("ns.foo#Bar$key").target("ns.foo#Baz").build())
                 .value(MemberShape.builder().id("ns.foo#Bar$value").target("ns.foo#Baz").build())
                 .build()
-                .accept(cases));
+                .accept(visitor));
         assertEquals(value, OperationShape.builder()
                 .id("ns.foo#Bar")
                 .build()
-                .accept(cases));
-        assertEquals(value, ResourceShape.builder().id("ns.foo#Bar").build().accept(cases));
+                .accept(visitor));
+        assertEquals(value, ResourceShape.builder().id("ns.foo#Bar").build().accept(visitor));
         assertEquals(value, ServiceShape.builder()
                 .id("ns.foo#Bar")
                 .version("2017-01-17")
                 .build()
-                .accept(cases));
-        assertEquals(value, StringShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, StructureShape.builder().id("ns.foo#Bar").build().accept(cases));
+                .accept(visitor));
+        assertEquals(value, StringShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, StructureShape.builder().id("ns.foo#Bar").build().accept(visitor));
         assertEquals(value, UnionShape.builder()
                 .id("ns.foo#Bar")
                 .addMember(MemberShape.builder().id("ns.foo#Bar$baz").target("ns.foo#Abc").build())
                 .build()
-                .accept(cases));
+                .accept(visitor));
         assertEquals(value, MemberShape.builder()
                 .id("ns.foo#Bar$member")
                 .target("ns.foo#Bam")
                 .build()
-                .accept(cases));
-        assertEquals(value, TimestampShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, ByteShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, ShortShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, IntegerShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, LongShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, FloatShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, DoubleShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, BigDecimalShape.builder().id("ns.foo#Bar").build().accept(cases));
-        assertEquals(value, BigIntegerShape.builder().id("ns.foo#Bar").build().accept(cases));
+                .accept(visitor));
+        assertEquals(value, TimestampShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, ByteShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, ShortShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, IntegerShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, LongShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, FloatShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, DoubleShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, BigDecimalShape.builder().id("ns.foo#Bar").build().accept(visitor));
+        assertEquals(value, BigIntegerShape.builder().id("ns.foo#Bar").build().accept(visitor));
     }
 }