base constructor for static analyses

roadtoagility · Feb 5, 2023 · f091cbc · f091cbc
1 parent 7947050
commit f091cbc
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/src/DFlow/Aggregates/AggregateBase.cs b/src/DFlow/Aggregates/AggregateBase.cs
@@ -13,6 +13,11 @@ namespace DFlow.Aggregates
     public abstract class AggregateBase<TChange, TEntityId>:BaseValidation,
         IAggregate<TChange> where TChange: EntityBase<TEntityId>
     {
+        protected AggregateBase(TChange root)
+        {
+            Root = root;
+        }
+
         protected TChange Root { get; private set; }
 
         protected void Apply(TChange item)

diff --git a/src/DFlow/BusinessObjects/EntityBase.cs b/src/DFlow/BusinessObjects/EntityBase.cs
@@ -48,7 +48,7 @@ public override string ToString()
 
     protected abstract IEnumerable<object> GetEqualityComponents();
 
-    public override bool Equals(object obj)
+    public override bool Equals(object? obj)
     {
         if (obj == null)
         {

diff --git a/tests/DFlow.Testing/Domain/PrimaryEntityTests.cs b/tests/DFlow.Testing/Domain/PrimaryEntityTests.cs
@@ -27,6 +27,6 @@ public void SecondaryEntity_Updated(PrimaryEntity primary, SecondaryEntity toUpd
     {
         primary.UpdateSecondary(toUpdate);
         var raisedEvent = primary.GetEvents()[0] as SecondaryEntityUpdatedEvent;
-        Assert.Equal(expected.Identity.Value, raisedEvent.SecondaryEntityId);
+        Assert.Equal(expected.Identity.Value, raisedEvent?.SecondaryEntityId);
     }
 }
diff --git a/tests/DFlow.Testing/Supporting/DomainObjects/Aggregates/PrimaryEntityAggregate.cs b/tests/DFlow.Testing/Supporting/DomainObjects/Aggregates/PrimaryEntityAggregate.cs
@@ -13,7 +13,8 @@ namespace DFlow.Testing.Supporting.DomainObjects.Aggregates;
 
 public sealed class PrimaryEntityAggregate : AggregateBase<PrimaryEntity, PrimaryEntityId>
 {
-    public PrimaryEntityAggregate(PrimaryEntity primaryEntity)
+    private PrimaryEntityAggregate(PrimaryEntity primaryEntity)
+        :base(primaryEntity)
     {
         if (primaryEntity.IsValid)
         {