updated to support mongodb v3.2 and above #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrai
reviewed
Dec 3, 2019
| }; | ||
|
|
||
| options.options = options.options || {}; | ||
|
|
||
| if (isNew) { | ||
| defaultOpt.autoReconnect = false; | ||
| // autoReconnect needs to be true to reconnect on failure, by default it is true in node-mongodb-native driver v2.2 and above |
There was a problem hiding this comment.
it is intentionally set to false,
cloud-native environment, if there is no connection to the db, the process is killed...
adrai
reviewed
Dec 3, 2019
| @@ -210,7 +218,7 @@ _.extend(MongoSessionStore.prototype, { | |||
|
|
|||
| if (!this.options.ignoreConcurrency) sess._hash = new ObjectID().toString(); | |||
|
|
|||
| this.sessions.update(query, sess, { upsert: true, safe: true }, function(err, modifiedCount) { | |||
| this.sessions.updateOne(query, { $set: sess }, { upsert: true }, function(err, modifiedCount) { | |||
There was a problem hiding this comment.
Can you write it backwards compatible?
i.e. if typeof this.sessions.updateOne === 'function' ? updateOne : update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the codes were obsolete and were not supported with latest mongodb versions so i have updated the code to support mongodb v3.2 and above.