Update valid_month and valid_expiry_year to coerce string arguments t…

…o integers

CHANGELOG

@@ -1,5 +1,6 @@
 = ActiveMerchant CHANGELOG
 
+* Update valid_month and valid_expiry_year to coerce string arguments to integers [cody]
 * Add support for displaying credit cards with PayPal Express. Use the :allow_guest_checkout => true option when setting up the transaction [Edward Ocampo-Gooding]
 * Use card_brand method for checking for checks in Sage and Beanstream [cody]
 * Add JCB and Diners Club to LinkPoint [Soleone]

lib/active_merchant/billing/credit_card_methods.rb

@@ -22,11 +22,11 @@ def self.included(base)
       end
 
       def valid_month?(month)
-        (1..12).include?(month)
+        (1..12).include?(month.to_i)
       end
 
       def valid_expiry_year?(year)
-        (Time.now.year..Time.now.year + 20).include?(year)
+        (Time.now.year..Time.now.year + 20).include?(year.to_i)
       end
 
       def valid_start_year?(year)

test/unit/credit_card_methods_test.rb

@@ -45,6 +45,19 @@ def test_should_be_able_to_identify_valid_start_years
     assert_false valid_start_year?(1987)
   end
 
+  def test_valid_start_year_can_handle_strings
+    assert valid_start_year?("2009")
+  end
+
+  def test_valid_month_can_handle_strings
+    assert valid_month?("1")
+  end
+
+  def test_valid_expiry_year_can_handle_strings
+    year = Time.now.year + 1
+    assert valid_expiry_year?(year.to_s)
+  end
+
   def test_should_be_able_to_identify_valid_issue_numbers
     assert valid_issue_number?(1)
     assert valid_issue_number?(10)