Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 localizer #60

Merged
merged 16 commits into from
Jan 26, 2022
Merged

Ros2 localizer #60

merged 16 commits into from
Jan 26, 2022

Conversation

elandini84
Copy link
Collaborator

New ROS2 localizer module added.

Some yarpmanager related test files (.xml application files, .ini configuration files, etc...) have also been added.

@elandini84 elandini84 requested review from randaz81 and ste93 January 13, 2022 15:37
@elandini84 elandini84 self-assigned this Jan 13, 2022
@ste93
Copy link
Contributor

ste93 commented Jan 13, 2022

app/rosExamples/launch/pycache/ros_navigation.launch.cpython-38.pyc is not needed
app/robotPathPlannerExamples/scripts/robotPathPlannerExample2_nws-nwc_ros2.xml is it better to add a sim one and a not sim one? because sim in the transformserver should have YARP_CLOCK variable setted

@elandini84
Copy link
Collaborator Author

app/rosExamples/launch/pycache/ros_navigation.launch.cpython-38.pyc is not needed app/robotPathPlannerExamples/scripts/robotPathPlannerExample2_nws-nwc_ros2.xml is it better to add a sim one and a not sim one? because sim in the transformserver should have YARP_CLOCK variable setted

@ste93 thanks for making me notice the unnecessary file. For the simulation issue, isn't it beeter to simply have the YARP_CLOCK variable set on the pc as an env variable? Or do you think it is better to set in the yarpmanager xml file?

@ste93
Copy link
Contributor

ste93 commented Jan 19, 2022

@elandini84 I was thinking about xml file since as Marco Said not all the Device wants it setted. Also if you put it in the xml is easier to remember and to noti e for future users

@randaz81 randaz81 merged commit 1e121b4 into robotology:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants