Extract two common lib info keys #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
|
I believe both keys were added to the UFO spec somewhat recently (about a year ago), so that would explain why they are missing from extractor. |
|
That's understandable. The ping was because there was no reaction to this PR in two weeks. :) |
|
Sorry @rimas-kudelis, it's a very busy period right now, this slid under the radar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure how useful this will be to anyone (I myself would delete both of these keys right away), but, just for the sake of completeness, why not export these two "common keys" in the lib:
public.openTypeHeadModifiedpublic.openTypePostUnderlinePosition