[HOPSWORKS-3069][Append] Always send Time Travel Type Hudi for Stream…

… Feature Group (logicalclocks#1064)
robzor92 · Apr 5, 2022 · 9e3f53b · 9e3f53b
1 parent aa8e9c2
commit 9e3f53b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/hopsworks-IT/src/test/ruby/spec/stream_feature_group_spec.rb b/hopsworks-IT/src/test/ruby/spec/stream_feature_group_spec.rb
@@ -34,6 +34,7 @@
         expect(parsed_json["featurestoreName"]).to eql(project.projectname.downcase + "_featurestore")
         expect(parsed_json["name"]).to eql(featuregroup_name)
         expect(parsed_json["type"]).to eql("streamFeatureGroupDTO")
+        expect(parsed_json["timeTravelFormat"]).to eql("HUDI")
         expect(parsed_json["onlineTopicName"]).to eql(project.id.to_s + "_" + parsed_json["id"].to_s + "_" +
                                                         featuregroup_name + "_" + parsed_json["version"].to_s + "_onlinefs")
 

diff --git a/...java/io/hops/hopsworks/common/featurestore/featuregroup/stream/StreamFeatureGroupDTO.java b/...java/io/hops/hopsworks/common/featurestore/featuregroup/stream/StreamFeatureGroupDTO.java
@@ -18,10 +18,12 @@
 
 import io.hops.hopsworks.common.featurestore.featuregroup.FeaturegroupDTO;
 import io.hops.hopsworks.persistence.entity.featurestore.featuregroup.Featuregroup;
+import io.hops.hopsworks.persistence.entity.featurestore.featuregroup.cached.TimeTravelFormat;
 import io.hops.hopsworks.persistence.entity.featurestore.featuregroup.cached.ValidationType;
 
 public class StreamFeatureGroupDTO extends FeaturegroupDTO {
   private ValidationType validationType = ValidationType.NONE;
+  private TimeTravelFormat timeTravelFormat = TimeTravelFormat.HUDI;
   private DeltaStreamerJobConf deltaStreamerJobConf;
   private Boolean onlineEnabled = true;
 
@@ -60,10 +62,20 @@ public void setOnlineEnabled(Boolean onlineEnabled) {
     this.onlineEnabled = onlineEnabled;
   }
 
+  public TimeTravelFormat getTimeTravelFormat() {
+    return timeTravelFormat;
+  }
+
+  public void setTimeTravelFormat(
+    TimeTravelFormat timeTravelFormat) {
+    this.timeTravelFormat = timeTravelFormat;
+  }
+
   @Override
   public String toString() {
     return "StreamFeatureGroupDTO{" +
       "validationType=" + validationType +
+      ", timeTravelFormat=" + timeTravelFormat +
       ", deltaStreamerJobConf=" + deltaStreamerJobConf +
       ", onlineEnabled=" + onlineEnabled +
       '}';