[HOPSWORKS-3252] Disable Kafka topic deletion for online feature grou…

…ps (logicalclocks#1022) (logicalclocks#1137)
robzor92 · Jul 14, 2022 · b72cbde · b72cbde
1 parent 3722fc8
commit b72cbde
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.../main/java/io/hops/hopsworks/common/featurestore/featuregroup/FeaturegroupController.java b/.../main/java/io/hops/hopsworks/common/featurestore/featuregroup/FeaturegroupController.java
@@ -563,6 +563,7 @@ public void deleteFeaturegroup(Featuregroup featuregroup, Project project, Users
           onlineFeaturegroupController.disableOnlineFeatureGroup(featuregroup, project, user);
         } else {
           // only topics need to be deleted, but no RonDB table
+          streamFeatureGroupController.deleteOfflineStreamFeatureGroupTopic(project, featuregroup);
         }
         //Delete associated delta streamer job
         fsJobManagerController.deleteDeltaStreamerJob(project,user, featuregroup);

diff --git a/.../hops/hopsworks/common/featurestore/featuregroup/online/OnlineFeaturegroupController.java b/.../hops/hopsworks/common/featurestore/featuregroup/online/OnlineFeaturegroupController.java
@@ -216,7 +216,8 @@ public void disableOnlineFeatureGroup(Featuregroup featureGroup, Project project
     dropMySQLTable(featureGroup, project, user);
     String topicName = onlineFeatureGroupTopicName(project.getId(), featureGroup.getId(),
       Utils.getFeaturegroupName(featureGroup));
-    deleteFeatureGroupKafkaTopic(project, topicName);
+    // HOPSWORKS-3252 - we keep kafka topics in order to avoid consumers getting blocked
+    // deleteFeatureGroupKafkaTopic(project, topicName);
   }
 
   public String buildCreateStatement(String dbName, String tableName, List<FeatureGroupFeatureDTO> features) {