Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

Sudo args #74

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sudo args #74

wants to merge 7 commits into from

Conversation

Erf-
Copy link

@Erf- Erf- commented Jul 24, 2015

Hi Rockymeza.
I added some 'sudo' args and the tests related to your connection and scannig methods. Then, I also impleted some tests on their calls. I implemented some dummydata to group all test variables and I modified their calls in test codes.

Erf- added 7 commits July 21, 2015 18:46
 Modifications qui seront validées :
	nouveau fichier: tests/test_scan.py
	nouveau fichier: wifi/dummydata.py
	modifié:         wifi/scan.py

Realisation du test du listing de reseaux disponibles en utilisant l'argument
'sudo'.

Le fichier dummydata contient les variables qui seront utilisees dans les
tests, a l'instar des fixtures de pytest.

Le fichier scan contient les modifications apportees par Yohan.
	nouveau fichier: tests/dummydata.py
	modifié:         tests/test_scan.py
        supprimé: wifi/dummydata
	modifié:         tests/dummydata.py
	modifié:         tests/test_scan.py
Ajout du test de l'appel du terminal sans 'sudo'.
	modifié:         tests/dummydata.py
	modifié:         tests/test_schemes.py
	modifié:         wifi/scheme.py

Modification de test_schemes de maniere a coller aux dummydata
	modifié:         tests/dummydata.py
	modifié:         tests/test_schemes.py
	modifié:         wifi/scheme.py

Ajout et test de la possibilité de réaliser la connection en passant par 'sudo'.
	modifié:         tests/test_parsing.py
Réajustement des dummydata pour coller avec test_parsing
	modifié:         tests/dummydata.py
	modifié:         tests/test_scan.py
	modifié:         tests/test_schemes.py

assert coffee.name == 'coffee'
assert coffee.options['wireless-essid'] == 'Coffee WiFi'
assert sch.work.name == 'work'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this no longer actually calls extract_schemes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Erf-/wifi/blob/sudo-args/tests/dummydata.py#L272
I do not think so. I call the extraction function there in the dummydata.

@rockymeza
Copy link
Owner

Hi @Erf-,

First of all thank you for this work, I appreciate it. I think that adding a sudo argument is important (see #66), but at the same time, there are too many changes in this pull request some of which I agree with and some of which I don't agree with.

It would be great if we could separate this pull request into two:

  1. add sudo argument
  2. refactor the tests

And we could disect/discuss them separately.

What do you think?

@Erf-
Copy link
Author

Erf- commented Jul 27, 2015

Ok I saw your comments and I am trying to match with them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants