-
Notifications
You must be signed in to change notification settings - Fork 151
Sudo args #74
base: master
Are you sure you want to change the base?
Sudo args #74
Conversation
Modifications qui seront validées : nouveau fichier: tests/test_scan.py nouveau fichier: wifi/dummydata.py modifié: wifi/scan.py Realisation du test du listing de reseaux disponibles en utilisant l'argument 'sudo'. Le fichier dummydata contient les variables qui seront utilisees dans les tests, a l'instar des fixtures de pytest. Le fichier scan contient les modifications apportees par Yohan.
nouveau fichier: tests/dummydata.py modifié: tests/test_scan.py supprimé: wifi/dummydata
modifié: tests/dummydata.py modifié: tests/test_scan.py Ajout du test de l'appel du terminal sans 'sudo'.
modifié: tests/dummydata.py modifié: tests/test_schemes.py modifié: wifi/scheme.py Modification de test_schemes de maniere a coller aux dummydata
modifié: tests/dummydata.py modifié: tests/test_schemes.py modifié: wifi/scheme.py Ajout et test de la possibilité de réaliser la connection en passant par 'sudo'.
modifié: tests/test_parsing.py Réajustement des dummydata pour coller avec test_parsing
modifié: tests/dummydata.py modifié: tests/test_scan.py modifié: tests/test_schemes.py
|
||
assert coffee.name == 'coffee' | ||
assert coffee.options['wireless-essid'] == 'Coffee WiFi' | ||
assert sch.work.name == 'work' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this no longer actually calls extract_schemes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/Erf-/wifi/blob/sudo-args/tests/dummydata.py#L272
I do not think so. I call the extraction function there in the dummydata.
Hi @Erf-, First of all thank you for this work, I appreciate it. I think that adding a sudo argument is important (see #66), but at the same time, there are too many changes in this pull request some of which I agree with and some of which I don't agree with. It would be great if we could separate this pull request into two:
And we could disect/discuss them separately. What do you think? |
Ok I saw your comments and I am trying to match with them. |
Hi Rockymeza.
I added some 'sudo' args and the tests related to your connection and scannig methods. Then, I also impleted some tests on their calls. I implemented some dummydata to group all test variables and I modified their calls in test codes.