Stop 'Page has no searchable content' error notif

- this error should never show a notif; it's not related to users
- addresses WorldBrain#838

src/activity-logger/background/log-page-visit.ts

@@ -110,7 +110,10 @@ export default class PageVisitLogger {
  })
  } catch (err) {
  this._tabManager.clearScheduledLog(tab.id)
- throw err
+
+ if (!(err instanceof searchIndex.PipelineError)) {
+ throw err
+ }
  }
  }
 
@@ -144,9 +147,15 @@ export default class PageVisitLogger {
  return
  }
 
- await this._createPage({
- pageDoc,
- visits: [internalTabState.visitTime],
- })
+ try {
+ await this._createPage({
+ pageDoc,
+ visits: [internalTabState.visitTime],
+ })
+ } catch (err) {
+ if (!(err instanceof searchIndex.PipelineError)) {
+ throw err
+ }
+ }
  }
 }

src/search/index.ts

@@ -8,3 +8,5 @@ export * from './on-demand-indexing'
 export * from './types'
 export * from './models'
 export { default as getDb } from './get-db'
+
+export { PipelineError } from './pipeline'

src/search/pipeline.ts

@@ -3,6 +3,8 @@ import transformPageText from '../util/transform-page-text'
 import { DEFAULT_TERM_SEPARATOR, extractContent } from './util'
 import { PipelineReq, PipelineRes } from './types'
 
+export class PipelineError extends Error {}
+
 /**
  * Derived from answer in: https://stackoverflow.com/a/23945027
  */
@@ -105,7 +107,9 @@ export default function pipeline({
  rejectNoContent &&
  (content == null || !content.fullText || !content.fullText.length)
  ) {
- return Promise.reject(new Error('Page has no searchable content'))
+ return Promise.reject(
+ new PipelineError('Page has no searchable content'),
+ )
  }
 
  // Extract all terms out of processed content