Merge pull request LaravelCollective#676 from open-source-contributio…

…ns/improve_phpunit_fixtures Improve PHPUnit fixtures
rohan1919-byte · Dec 15, 2020 · db28e1a · db28e1a
2 parents af6e88d + 74384b0
commit db28e1a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/tests/FormAccessibleTest.php b/tests/FormAccessibleTest.php
@@ -14,7 +14,7 @@
 
 class FormAccessibleTest extends PHPUnit\Framework\TestCase
 {
- public function setUp()
+ protected function setUp(): void
  {
  Capsule::table('models')->truncate();
  Model::unguard();

diff --git a/tests/FormBuilderTest.php b/tests/FormBuilderTest.php
@@ -22,7 +22,7 @@ class FormBuilderTest extends PHPUnit\Framework\TestCase
  /**
  * Setup the test environment.
  */
- public function setUp()
+ protected function setUp(): void
  {
  $this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/foo', 'GET'));
  $this->viewFactory = m::mock(Factory::class);
@@ -46,7 +46,7 @@ public function setUp()
  /**
  * Destroy the test environment.
  */
- public function tearDown()
+ protected function tearDown(): void
  {
  m::close();
  }

diff --git a/tests/HtmlBuilderTest.php b/tests/HtmlBuilderTest.php
@@ -13,14 +13,14 @@ class HtmlBuilderTest extends PHPUnit\Framework\TestCase
  /**
  * Setup the test environment.
  */
- public function setUp()
+ protected function setUp(): void
  {
  $this->urlGenerator = new UrlGenerator(new RouteCollection(), Request::create('/foo', 'GET'));
  $this->viewFactory = m::mock(Factory::class);
  $this->htmlBuilder = new HtmlBuilder($this->urlGenerator, $this->viewFactory);
  }
 
- public function tearDown()
+ protected function tearDown(): void
  {
  m::close();
  }