Fixed a bug where crashes in node tests would stall rooibos (#322)

rokucommunity · Mar 4, 2025 · 64ccc45 · 64ccc45
2 parents 023a363 + 143c2a4
commit 64ccc45
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/framework/src/source/rooibos/BaseTestSuite.bs b/framework/src/source/rooibos/BaseTestSuite.bs
@@ -242,6 +242,9 @@ namespace rooibos
         catch error
           'bs:disable-next-line
           m.currentResult.crash("test crashed!", error)
+          if rooibos.promises.isPromise(test.deferred)
+            rooibos.promises.reject(error, test.deferred)
+          end if
         end try
       else
         test.run()

diff --git a/tests/src/source/Async.spec.bs b/tests/src/source/Async.spec.bs
@@ -50,5 +50,16 @@ namespace tests
 
       delayCall(0.02, SetLabelText)
     end function
+
+    '+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+    @describe("Crashes in Node tests")
+    '+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+
+    @async
+    @it("should capture the crash and fail")
+    function _()
+      throw "some error in node tests"
+    end function
+
   end class
 end namespace