Added the ability to have duplicate test names (#317)

rokucommunity · Feb 24, 2025 · cdbba6a · cdbba6a
2 parents b3998f3 + 1141def
commit cdbba6a
Show file tree

Hide file tree

Showing 10 changed files with 898 additions and 863 deletions.
diff --git a/bsc-plugin/src/lib/rooibos/MockUtil.ts b/bsc-plugin/src/lib/rooibos/MockUtil.ts
@@ -133,7 +133,7 @@ export class MockUtil {
     gatherGlobalMethodMocks(testSuite: TestSuite) {
         // console.log('gathering global method mocks for testSuite', testSuite.name);
         for (let group of [...testSuite.testGroups.values()].filter((tg) => tg.isIncluded)) {
-            for (let testCase of [...group.testCases.values()].filter((tc) => tc.isIncluded)) {
+            for (let testCase of [...group.testCases].filter((tc) => tc.isIncluded)) {
                 this.gatherMockedGlobalMethods(testSuite, testCase);
             }
         }

diff --git a/bsc-plugin/src/lib/rooibos/RooibosSessionInfo.ts b/bsc-plugin/src/lib/rooibos/RooibosSessionInfo.ts
@@ -91,15 +91,15 @@ export class SessionInfo {
                     testGroup.isIncluded = true;
                     if (testGroup.isIgnored) {
                         this.ignoredTestNames.push(testGroup.name + ' [WHOLE GROUP]');
-                        this.ignoredCount += testGroup.testCases.size;
+                        this.ignoredCount += testGroup.testCases.length;
                     }
                 }
 
                 if (testGroup.isIncluded) {
                     if (testGroup.isIncluded) {
                         this.groupsCount++;
                     }
-                    let testCases = [...testGroup.testCases.values()];
+                    let testCases = [...testGroup.testCases];
 
                     for (let testCase of testCases) {
                         testCase.isIncluded = false;

diff --git a/bsc-plugin/src/lib/rooibos/TestGroup.ts b/bsc-plugin/src/lib/rooibos/TestGroup.ts
@@ -21,19 +21,15 @@ export class TestGroup extends TestBlock {
     }
 
     public testSuite: TestSuite;
-    public testCases = new Map<string, TestCase>();
+    public testCases: Array<TestCase> = [];
 
     public addTestCase(testCase: TestCase) {
-        this.testCases.set(testCase.name + (testCase.isParamTest ? testCase.paramTestIndex.toString() : ''), testCase);
+        this.testCases.push(testCase);
         this.hasIgnoredTests = this.hasIgnoredTests || testCase.isIgnored;
         this.hasSoloTests = this.hasSoloTests || testCase.isSolo;
         this.hasAsyncTests = this.hasAsyncTests || testCase.isAsync;
     }
 
-    public getTestCases(): TestCase[] {
-        return [...this.testCases.values()];
-    }
-
     public modifyAssertions(testCase: TestCase, noEarlyExit: boolean, editor: AstEditor, namespaceLookup: Map<string, NamespaceContainer>, scope: Scope) {
         //for each method
         //if assertion
@@ -201,7 +197,7 @@ export class TestGroup extends TestBlock {
     }
 
     public asText(): string {
-        let testCaseText = [...this.testCases.values()].filter((tc) => tc.isIncluded).map((tc) => tc.asText());
+        let testCaseText = [...this.testCases].filter((tc) => tc.isIncluded).map((tc) => tc.asText());
 
         return `
             {

diff --git a/bsc-plugin/src/lib/rooibos/TestSuite.ts b/bsc-plugin/src/lib/rooibos/TestSuite.ts
@@ -94,6 +94,7 @@ export class TestSuite extends TestBlock {
     public hasSoloGroups = false;
     public isNodeTest = false;
     public session: RooibosSession;
+    public registeredTestCount = 0;
 
     public addGroup(group: TestGroup) {
         this.testGroups.set(group.name, group);