Fix edge case

ronaldoussoren · Apr 21, 2022 · 51179bd · 51179bd
1 parent 198017f
commit 51179bd
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/py2app/util.py b/py2app/util.py
@@ -158,7 +158,7 @@ def find_version(fn: os.PathLike) -> typing.Optional[str]:
         # would require handling encoding tokens.
         source = stream.read()
 
-    module_ast = ast.parse(source, fn)
+    module_ast = ast.parse(source, str(fn))
 
     # Look for a toplevel assignment statement that sets
     # __version__ to a constant value
@@ -172,6 +172,8 @@ def find_version(fn: os.PathLike) -> typing.Optional[str]:
             continue
 
         for t in node.targets:
+            if not isinstance(t, ast.Name):
+                continue
             if t.id == "__version__":
                 value = node.value
                 if isinstance(value, ast.Constant) and isinstance(value.value, str):

diff --git a/py2app_tests/test_utils.py b/py2app_tests/test_utils.py
@@ -26,6 +26,9 @@ def test_multi_part(self):
     def test_multi_target(self):
         self.assert_version_equals("b = __version__ = 'c'", "c")
 
+    def test_multi_target2(self):
+        self.assert_version_equals("b[x] = __version__ = 'c'", "c")
+
     def test_not_string(self):
         self.assert_version_equals("__version__ = 42", None)