Fix a number of resource warnings

ronaldoussoren · Apr 10, 2022 · b0e90c4 · b0e90c4
1 parent 531dba5
commit b0e90c4
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 3 deletions.
diff --git a/py2app_tests/test_app_with_scripts.py b/py2app_tests/test_app_with_scripts.py
@@ -166,6 +166,13 @@ def start_app(self):
         return p
 
     def tearDown(self):
+        if hasattr(self, "_p"):
+            self._p.send_signal(9)
+            try:
+                self._p.communicate()
+            except ValueError:
+                pass
+            self._p.wait()
         kill_child_processes()
         time.sleep(1)
 

diff --git a/py2app_tests/test_basic_app_with_encoding.py b/py2app_tests/test_basic_app_with_encoding.py
@@ -112,6 +112,15 @@ def tearDownClass(cls):
         time.sleep(2)
 
     def tearDown(self):
+        if hasattr(self, "_p"):
+            self._p.stdout.close()
+            try:
+                self._p.communicate()
+            except ValueError:
+                pass
+
+            self._p.send_signal(9)
+            self._p.wait()
         kill_child_processes()
         time.sleep(1)
 
@@ -120,7 +129,7 @@ def start_app(self):
         # stdin and stdout are connected to pipes.
         path = os.path.join(self.app_dir, "dist/BasicApp.app/Contents/MacOS/BasicApp")
 
-        p = subprocess.Popen(
+        self._p = p = subprocess.Popen(
             [path],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,

diff --git a/py2app_tests/test_explicit_includes.py b/py2app_tests/test_explicit_includes.py
@@ -65,6 +65,14 @@ def tearDownClass(cls):
         time.sleep(2)
 
     def tearDown(self):
+        if hasattr(self, "_p"):
+            try:
+                self._p.communicate()
+            except ValueError:
+                pass
+
+            self._p.send_signal(9)
+            self._p.wait()
         kill_child_processes()
         time.sleep(1)
 
@@ -73,7 +81,7 @@ def start_app(self):
         # stdin and stdout are connected to pipes.
         path = os.path.join(self.app_dir, "dist/BasicApp.app/Contents/MacOS/BasicApp")
 
-        p = subprocess.Popen(
+        self._p = p = subprocess.Popen(
             [path],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,

diff --git a/py2app_tests/test_package_data.py b/py2app_tests/test_package_data.py
@@ -104,6 +104,13 @@ def tearDownClass(cls):
         time.sleep(2)
 
     def tearDown(self):
+        if hasattr(self, "_p"):
+            self._p.send_signal(9)
+            try:
+                self._p.communicate()
+            except ValueError:
+                pass
+            self._p.wait()
         kill_child_processes()
         time.sleep(1)
 
@@ -112,7 +119,7 @@ def start_app(self):
         # stdin and stdout are connected to pipes.
         path = os.path.join(self.app_dir, "dist/BasicApp.app/Contents/MacOS/BasicApp")
 
-        p = subprocess.Popen(
+        self._p = p = subprocess.Popen(
             [path],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,