Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

Rewrote plugin. See README.md for more info. #11

Merged
merged 1 commit into from
Apr 12, 2015
Merged

Rewrote plugin. See README.md for more info. #11

merged 1 commit into from
Apr 12, 2015

Conversation

QWp6t
Copy link
Member

@QWp6t QWp6t commented Apr 12, 2015

  • Update to Apache Server Configs v2.14.0
  • Rewrote plugin as a class
  • Rewrote logic so that server and WordPress configurations are only checked when plugin is actively in use
  • Added filters to provide users with more control over the rules that are being applied
  • Added a dedicated WordPress section to the bottom of h5bp-htaccess

@QWp6t
Copy link
Member Author

QWp6t commented Apr 12, 2015

This closes the other two issues, by the way.

swalkinshaw
swalkinshaw reviewed Apr 12, 2015
View reviewed changes
wp-h5bp-htaccess.php
$htaccess_file = $home_path . '.htaccess';
$mod_rewrite_enabled = function_exists('got_mod_rewrite') ? got_mod_rewrite() : false;
private static $instance;
private static $marker = 'Roots Server Config';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think a const is more appropriate here?

const MARKER = 'Roots Server Config';

@QWp6t QWp6t force-pushed the QWp6t-2.0.0 branch 2 times, most recently from 8eb65df to 37d6af9 Compare April 12, 2015 21:31
@QWp6t
Copy link
Member Author

QWp6t commented Apr 12, 2015

Done.

@swalkinshaw
Copy link
Member

👍 assuming it works!

@QWp6t
Copy link
Member Author

QWp6t commented Apr 12, 2015

I've tested in a Bedrock environment and I just tested it in a traditional WordPress environment. Worked for me on both of those. I also tested all of the examples I used in README.md.

Everything checks out on my end.

@QWp6t
Rewrote plugin. See README.md for more info.
04190bf 
* Update to Apache Server Configs v2.14.0
* Rewrote plugin as a class
* Rewrote logic so that server and WordPress configurations are only
  checked when plugin is actively in use
* Added filters to provide users with more control over the rules that are
  being applied
* Added a dedicated WordPress section to the bottom of h5bp-htaccess
retlehs added a commit that referenced this pull request Apr 12, 2015
@retlehs
Merge pull request #11 from roots/QWp6t-2.0.0
486775f 
Rewrote plugin. See README.md for more info.
@retlehs retlehs merged commit 486775f into master Apr 12, 2015
@retlehs retlehs deleted the QWp6t-2.0.0 branch April 12, 2015 22:28
This was referenced Apr 12, 2015
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QWp6t @swalkinshaw @retlehs