fix requirenamespace

also, fix redirected links
ropensci · Sep 2, 2020 · 4258f1a · 4258f1a
1 parent 60be9e8
commit 4258f1a
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -66,7 +66,7 @@ Suggests:
     magrittr,
     formatR
 SystemRequirements: 
-URL: https://github.com/ropensci/MODIStsp, https://docs.ropensci.org/MODIStsp
+URL: https://github.com/ropensci/MODIStsp/, https://docs.ropensci.org/MODIStsp
 BugReports: https://github.com/ropensci/MODIStsp/issues
 LazyData: true
 VignetteBuilder: knitr

diff --git a/R/MODIStsp.R b/R/MODIStsp.R
@@ -355,7 +355,7 @@ MODIStsp <- function(...,
                   "leafem", "mapedit",
                   "magrittr")
     gui_deps_missing <- !sapply(gui_deps, requireNamespace, quietly = TRUE)
-    
+
     if (sum(gui_deps_missing) > 0) {
       stop("You need to install the following Suggested packages to use the MODIStsp GUI.
            Please install them with:
@@ -368,6 +368,10 @@ MODIStsp <- function(...,
       requireNamespace("shinydashboard")
       requireNamespace("shinyFiles")
       requireNamespace("shinyalert")
+      requireNamespace("shinyjs")
+      requireNamespace("leafem")
+      requireNamespace("rappdirs")
+      requireNamespace("mapedit")
       requireNamespace("magrittr")
     }
     #nocov end

diff --git a/README.Rmd b/README.Rmd
@@ -18,7 +18,7 @@ knitr::opts_chunk$set(
 [![Travis-CI Build Status](https://travis-ci.org/ropensci/MODIStsp.svg?branch=master)](https://travis-ci.org/ropensci/MODIStsp)
 [![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.1972039.svg)](https://doi.org/10.5281/zenodo.1972039)
 [![Coverage Status](https://img.shields.io/codecov/c/github/ropensci/MODIStsp/master.svg)](https://codecov.io/github/ropensci/MODIStsp?branch=master)
-[![](https://badges.ropensci.org/184_status.svg)](https://github.com/ropensci/onboarding/issues/184)
+[![](https://badges.ropensci.org/184_status.svg)](https://github.com/ropensci/software-review/issues/184)
 
 # MODIStsp <img src='man/figures/logo.png' align="right" height="139" />
 

diff --git a/vignettes/MODIStsp.Rmd b/vignettes/MODIStsp.Rmd
@@ -350,7 +350,7 @@ argument:
       
 #### On Windows
 
-- create a Task following [these instructions](https://technet.microsoft.com/en-us/library/cc748993.aspx); add the path of the MODIStsp.bat launcher as Action (point 6), and specifying  `-g -s "X:/yourpath/youroptions.json"` as argument.
+- create a Task following [these instructions](https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/cc748993(v=ws.11)?redirectedfrom=MSDN); add the path of the MODIStsp.bat launcher as Action (point 6), and specifying  `-g -s "X:/yourpath/youroptions.json"` as argument.
 
 # Outputs Format and Naming Conventions
 

diff --git a/vignettes/standalone_execution.Rmd b/vignettes/standalone_execution.Rmd
@@ -66,6 +66,6 @@ following row:
       
 ## _On Windows_
 
-- create a Task following [this instructions](https://technet.microsoft.com/en-us/library/cc748993.aspx)
+- create a Task following [this instructions](https://docs.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-R2-and-2008/cc748993(v=ws.11)?redirectedfrom=MSDN)
 - add the path of the MODIStsp.bat launcher as Action (point 6), 
 specifying  `-g -s "X:/yourpath/youroptions.json"` as argument.