Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaled jtc #1191

Open
wants to merge 57 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
d1fcba0
Add scaling factor to JTC
fmauch Oct 4, 2023
55c3bb0
use reset+initRT due to missing writeFromRT
fmauch Oct 10, 2023
79a8b7c
Reformat scaling the time period
fmauch Mar 21, 2024
600ba71
synchronization of scaling factor with hw optional, add service for s…
fmauch Mar 22, 2024
c01b1ad
Improve scaling exchange with hardware
fmauch Mar 27, 2024
c003883
Check command interface name when setting speed scaling
fmauch Apr 3, 2024
aa63e5d
Update code formatting
fmauch Apr 3, 2024
821c88d
Do not advertise speed scaling service unless only position interface is
fmauch Apr 7, 2024
f7d0ae0
WIP: Adding documentation about speed scaling
fmauch Apr 7, 2024
71ccb39
Use a subscriber instead of a service
fmauch Jul 3, 2024
1fb38b8
Do not put the time_data_ into a RealtimeBuffer
fmauch Jul 3, 2024
6890d6e
Fix goal time violated
Jul 3, 2024
b5a567d
Merge remote-tracking branch 'origin/master' into scaled_jtc
fmauch Jul 3, 2024
908b539
Use custom message to subscribe speed scaling
fmauch Jul 3, 2024
1e66e44
Add scaling factor to controller state
fmauch Jul 3, 2024
7daf240
Code formatting
fmauch Jul 3, 2024
66abfd9
Allow scaling factors greater than 1
fmauch Jul 3, 2024
45fa036
Add parameter validator for default scaling factor
fmauch Jul 3, 2024
5e9592b
More formatting...
fmauch Jul 3, 2024
42394b9
Remove unnecessary iostream include
fmauch Jul 4, 2024
ba5fecb
REVERT_ME: Use dev branch for control_msgs
fmauch Jul 4, 2024
4b2f18c
Write back scaling factor to buffer when updated from hardware
fmauch Jul 4, 2024
76e5cab
Remove additional time_data structure in update method
fmauch Jul 4, 2024
b22ce07
Use std::atomic for scaling factor buff
fmauch Jul 4, 2024
7e88744
Use transient_local for the speed scaling topic subscriber
fmauch Jul 4, 2024
d2130e0
Added documentation on tolerance effects
fmauch Jul 5, 2024
915bfd3
Added a short explanation of scaling
fmauch Jul 5, 2024
90c6d45
Use a ordering-safe reference for scaling command and state interfaces
fmauch Jul 8, 2024
77e78ce
Merge branch 'master' into scaled_jtc
fmauch Jul 23, 2024
0a3b974
REVERT_ME Use my version of control_msgs
fmauch Jul 23, 2024
09bea48
Use period directly instead of calculating an own period
fmauch Jul 23, 2024
9658347
Merge branch 'master' into scaled_jtc
fmauch Aug 8, 2024
0dba992
Set update rate in testing controller
fmauch Aug 8, 2024
a96dd54
Tests: Call controller.configure() instead of controller.get_node().c…
fmauch Aug 28, 2024
d55fea7
Sample trajectory at point t+dT
fmauch Sep 12, 2024
9400838
Update trajectory_controller_tests
fmauch Oct 7, 2024
777e5a9
Merge branch 'master' into jtc_tdt
fmauch Oct 8, 2024
62003f8
Fix period calculation in trajectory_actions test
fmauch Oct 13, 2024
1f9bfb4
Sample trajectory based on the sum of periods instead of the absolute…
fmauch Oct 13, 2024
adc270f
Merge branch 'jtc_sum_periods' into scaled_jtc
fmauch Oct 13, 2024
0d08c38
Cleanup some logging
fmauch Oct 14, 2024
35dbc4f
Merge remote-tracking branch 'origin/master' into scaled_jtc_merged
fmauch Dec 1, 2024
c56ce2b
Add test for scaled trajectory execution
fmauch Dec 1, 2024
b395104
Merge remote-tracking branch 'origin/master' into scaled_jtc
fmauch Dec 3, 2024
b101360
Use master branch of control_msgs repo
christophfroehlich Dec 3, 2024
21c9c4d
Apply suggestions from code review
fmauch Dec 4, 2024
9d5c981
Update tolerances documentation
fmauch Dec 4, 2024
a2d319b
Only log set scaling factor if it is changed
fmauch Dec 4, 2024
5d2b852
Remove duplicate reading period from parameter
fmauch Dec 4, 2024
7844221
Make trajectory test use tolerances
fmauch Dec 4, 2024
a74f94d
Check goal tolerance from error to next command
fmauch Dec 7, 2024
57ec2a5
Add a test that verifies that the JTC samples the trajectory correctly
fmauch Dec 7, 2024
0b760bc
Fix goal constraint specifications in test
fmauch Dec 7, 2024
d141556
Merge remote-tracking branch 'origin/master' into scaled_jtc
fmauch Jan 15, 2025
2abc954
Adding some tests for setting the speed scaling factor
fmauch Jan 15, 2025
94d851a
Merge remote-tracking branch 'origin/master' into scaled_jtc
fmauch Jan 26, 2025
06c3dd7
Add tests using speed_scaling hardware interfaces
fmauch Jan 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'origin/master' into scaled_jtc
  • Loading branch information
fmauch committed Jul 3, 2024
commit b5a567d012559518a0bae8dc7777f188947cc9ce
Original file line number Diff line number Diff line change
Expand Up @@ -949,7 +949,7 @@ controller_interface::CallbackReturn JointTrajectoryController::on_activate(
params_ = param_listener_->get_params();

// parse remaining parameters
default_tolerances_ = get_segment_tolerances(params_);
default_tolerances_ = get_segment_tolerances(logger, params_);
// Setup time_data buffer used for scaling
TimeData time_data;
time_data_.time = get_node()->now();
Expand Down
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.