A few small changes to get it building on my system. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this line fails because the CMake Module provided by Fast-RTPS is incomplete right now. it happens to compile without the module, so I just disabled it
richiprosima
added a commit
that referenced
this pull request
Sep 2, 2015
A few small changes to get it building on my system.
|
Thanks for the contribution |
mauropasse
pushed a commit
to mauropasse/rmw_fastrtps
that referenced
this pull request
Oct 14, 2020
…cutor Add support for events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One thing I had to do was disable the find_package(fastrtps) call.
This is because the CMake module for Fast-RTPS is incomplete:
https://github.com/eProsima/ROS-RMW-Fast-RTPS-cpp/blob/master/fastrtps_cmake_module/cmake/Modules/FindFastRTPS.cmake#L48
This results in a syntax error from CMake.
It happens to compile even without the find_package rule, so I disabled it for now.
However, it should really be finished and added back to this CMake logic.